From dd8b462c6459791fdabe97dceab56587da711577 Mon Sep 17 00:00:00 2001 From: Erik Pilkington Date: Wed, 10 Apr 2019 21:18:21 +0000 Subject: [PATCH] Fix a test, NFC This test was duplicated, and the last declaration had some syntax errors since the invalid attribute caused the @implementation to be skipped by the parser. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@358136 91177308-0d34-0410-b5e6-96231b3b80d8 --- .../CodeGenObjC/objc-asm-attribute-neg-test.m | 34 ------------------- test/SemaObjC/objc-asm-attribute-neg-test.m | 16 ++++++--- 2 files changed, 12 insertions(+), 38 deletions(-) delete mode 100644 test/CodeGenObjC/objc-asm-attribute-neg-test.m diff --git a/test/CodeGenObjC/objc-asm-attribute-neg-test.m b/test/CodeGenObjC/objc-asm-attribute-neg-test.m deleted file mode 100644 index de809d8a04..0000000000 --- a/test/CodeGenObjC/objc-asm-attribute-neg-test.m +++ /dev/null @@ -1,34 +0,0 @@ -// RUN: %clang_cc1 -fsyntax-only -verify -Wno-objc-root-class %s -// rdar://16462586 - -__attribute__((objc_runtime_name("MySecretNamespace.Protocol"))) -@protocol Protocol -@end - -__attribute__((objc_runtime_name("MySecretNamespace.Message"))) -@interface Message { -__attribute__((objc_runtime_name("MySecretNamespace.Message"))) // expected-error {{'objc_runtime_name' attribute only applies to Objective-C interfaces and Objective-C protocols}} - id MyIVAR; -} -__attribute__((objc_runtime_name("MySecretNamespace.Message"))) -@property int MyProperty; // expected-error {{prefix attribute must be followed by an interface or protocol}}}} - -- (int) getMyProperty __attribute__((objc_runtime_name("MySecretNamespace.Message"))); // expected-error {{'objc_runtime_name' attribute only applies to}} - -- (void) setMyProperty : (int) arg __attribute__((objc_runtime_name("MySecretNamespace.Message"))); // expected-error {{'objc_runtime_name' attribute only applies to}} - -@end - -__attribute__((objc_runtime_name("MySecretNamespace.ForwardClass"))) -@class ForwardClass; // expected-error {{prefix attribute must be followed by an interface or protocol}} - -__attribute__((objc_runtime_name("MySecretNamespace.ForwardProtocol"))) -@protocol ForwardProtocol; - -__attribute__((objc_runtime_name("MySecretNamespace.Message"))) -@implementation Message // expected-error {{prefix attribute must be followed by an interface or protocol}} -__attribute__((objc_runtime_name("MySecretNamespace.Message"))) -- (id) MyMethod { - return MyIVAR; -} -@end diff --git a/test/SemaObjC/objc-asm-attribute-neg-test.m b/test/SemaObjC/objc-asm-attribute-neg-test.m index 98f39fb900..f32abd2206 100644 --- a/test/SemaObjC/objc-asm-attribute-neg-test.m +++ b/test/SemaObjC/objc-asm-attribute-neg-test.m @@ -33,10 +33,18 @@ __attribute__((objc_runtime_name("MySecretNamespace.ForwardClass"))) __attribute__((objc_runtime_name("MySecretNamespace.ForwardProtocol"))) @protocol ForwardProtocol; -__attribute__((objc_runtime_name("MySecretNamespace.Message"))) -@implementation Message // expected-error {{prefix attribute must be followed by an interface or protocol}} -__attribute__((objc_runtime_name("MySecretNamespace.Message"))) -- (id) MyMethod { +@implementation Message +// expected-error@+1 {{'objc_runtime_name' attribute only applies to Objective-C interfaces and Objective-C protocols}} +- (id) MyMethod __attribute__((objc_runtime_name("MySecretNamespace.Message"))) { return MyIVAR; } + +-(int)getMyProperty { return 0; } +-(void)setMyProperty:(int)arg {} @end + +@interface NoImpl @end + +__attribute__((objc_runtime_name("MySecretNamespace.Message"))) +// expected-error@+1 {{prefix attribute must be followed by an interface or protocol}} +@implementation NoImpl @end -- 2.40.0