From dd56fbadb4b5026a0484ebabdc36fd19ec5d6522 Mon Sep 17 00:00:00 2001 From: "Todd C. Miller" Date: Sun, 15 Feb 2009 20:53:49 +0000 Subject: [PATCH] Rename pwstars to pwfeedback --- def_data.c | 4 ++-- def_data.h | 4 ++-- def_data.in | 4 ++-- sudoers.pod | 10 +++++----- tgetpass.c | 4 ++-- 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/def_data.c b/def_data.c index 311c21e46..6a83be43e 100644 --- a/def_data.c +++ b/def_data.c @@ -303,8 +303,8 @@ struct sudo_defs_types sudo_defs_table[] = { "Allow sudo to prompt for a password even if it would be visisble", NULL, }, { - "pwstars", T_FLAG, - "Print a stars at the password prompt when there is user input", + "pwfeedback", T_FLAG, + "Provide visual feedback at the password prompt when there is user input", NULL, }, { "fast_glob", T_FLAG, diff --git a/def_data.h b/def_data.h index 1859941c2..5f38375ef 100644 --- a/def_data.h +++ b/def_data.h @@ -138,8 +138,8 @@ #define I_SUDOERS_LOCALE 68 #define def_visiblepw (sudo_defs_table[69].sd_un.flag) #define I_VISIBLEPW 69 -#define def_pwstars (sudo_defs_table[70].sd_un.flag) -#define I_PWSTARS 70 +#define def_pwfeedback (sudo_defs_table[70].sd_un.flag) +#define I_PWFEEDBACK 70 #define def_fast_glob (sudo_defs_table[71].sd_un.flag) #define I_FAST_GLOB 71 diff --git a/def_data.in b/def_data.in index 1a41399bf..037019767 100644 --- a/def_data.in +++ b/def_data.in @@ -223,9 +223,9 @@ sudoers_locale visiblepw T_FLAG "Allow sudo to prompt for a password even if it would be visisble" -pwstars +pwfeedback T_FLAG - "Print a stars at the password prompt when there is user input" + "Provide visual feedback at the password prompt when there is user input" fast_glob T_FLAG "Use faster globbing that is less accurate but does not access the filesystem" diff --git a/sudoers.pod b/sudoers.pod index 5fcd5abbc..6767e7e1b 100644 --- a/sudoers.pod +++ b/sudoers.pod @@ -660,15 +660,15 @@ user's existing group vector is left unaltered. The real and effective group IDs, however, are still set to match the target user. This flag is I by default. -=item pwstars +=item pwfeedback By default, B reads the password like most other Unix programs, by turning off echo until the user hits the return (or enter) key. Some users become confused by this as it appears to them that B -has hung at this point. When I is set, B will print -a star for each character of the password the user enters. Note -that this does have a security impact, as an onlooker will be able -to determine the length of the password being entered. +has hung at this point. When I is set, B will +provide visual feedback when the user presses a key. Note that +this does have a security impact as an onlooker may be able to +determine the length of the password being entered. This flag is I by default. =item requiretty diff --git a/tgetpass.c b/tgetpass.c index ab1b8adcc..2bd3db8c5 100644 --- a/tgetpass.c +++ b/tgetpass.c @@ -119,7 +119,7 @@ restart: (void) sigaction(SIGTTIN, &sa, &savettin); (void) sigaction(SIGTTOU, &sa, &savettou); - if (def_pwstars) + if (def_pwfeedback) neednl = term_raw(input); else neednl = term_noecho(input); @@ -131,7 +131,7 @@ restart: if (timeout > 0) alarm(timeout); - pass = getln(input, buf, sizeof(buf), def_pwstars); + pass = getln(input, buf, sizeof(buf), def_pwfeedback); alarm(0); save_errno = errno; -- 2.40.0