From dcefa205830a7307365f4dfb9faeaa889117d3c9 Mon Sep 17 00:00:00 2001 From: Matthew Fernandez Date: Sun, 6 Mar 2022 16:47:16 -0800 Subject: [PATCH] remove Criterion submodule MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Criterion is a testing framework that has been used for writing Graphviz unit tests in the past (see tests/unit_tests). These unit tests are not currently enabled. However, Windows CI unconditionally checks out all submodules, thus pulling in a version of Criterion that goes unused. This change removes the previously described behavior. If/when the Criterion-based unit tests are resurrected, an up to date version of Criterion can be pulled in via a package manager or the Windows build dependencies repository¹ instead. This change should slightly accelerate Windows CI jobs. ¹ https://gitlab.com/graphviz/graphviz-build-utilities --- .gitmodules | 3 --- dependencies/criterion | 1 - 2 files changed, 4 deletions(-) delete mode 160000 dependencies/criterion diff --git a/.gitmodules b/.gitmodules index edc51d30b..c4422583f 100644 --- a/.gitmodules +++ b/.gitmodules @@ -1,9 +1,6 @@ [submodule "windows/dependencies/graphviz-build-utilities"] path = windows/dependencies/graphviz-build-utilities url = https://gitlab.com/graphviz/graphviz-build-utilities -[submodule "dependencies/criterion"] - path = dependencies/criterion - url = https://github.com/Snaipe/Criterion.git [submodule "windows/dependencies/libraries"] path = windows/dependencies/libraries url = https://gitlab.com/graphviz/graphviz-windows-dependencies diff --git a/dependencies/criterion b/dependencies/criterion deleted file mode 160000 index 301d143ea..000000000 --- a/dependencies/criterion +++ /dev/null @@ -1 +0,0 @@ -Subproject commit 301d143ea42c024f22b673b69c72a4cb3c8d151f -- 2.50.1