From dcca3661450851bff114774c5f3ce8e753ff67ab Mon Sep 17 00:00:00 2001 From: Kang Zhang Date: Sun, 30 Dec 2018 07:48:09 +0000 Subject: [PATCH] [PowerPC] Fix ADDE, SUBE do not know how to promote operator Summary: This patch is created to fix the Bugzilla bug 39815: https://bugs.llvm.org/show_bug.cgi?id=39815 This patch is to support promotion integer result for the instruction ADDE, SUBE. Reviewed By: hfinkel Differential Revision: https://reviews.llvm.org/D56119 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@350161 91177308-0d34-0410-b5e6-96231b3b80d8 --- .../SelectionDAG/LegalizeIntegerTypes.cpp | 5 +++ test/CodeGen/PowerPC/pr39815.ll | 31 +++++++++++++++++++ 2 files changed, 36 insertions(+) create mode 100644 test/CodeGen/PowerPC/pr39815.ll diff --git a/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp b/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp index 096d2ab5d82..a42e89da994 100644 --- a/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp +++ b/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp @@ -140,6 +140,8 @@ void DAGTypeLegalizer::PromoteIntegerResult(SDNode *N, unsigned ResNo) { case ISD::SMULO: case ISD::UMULO: Res = PromoteIntRes_XMULO(N, ResNo); break; + case ISD::ADDE: + case ISD::SUBE: case ISD::ADDCARRY: case ISD::SUBCARRY: Res = PromoteIntRes_ADDSUBCARRY(N, ResNo); break; @@ -865,6 +867,9 @@ SDValue DAGTypeLegalizer::PromoteIntRes_UADDSUBO(SDNode *N, unsigned ResNo) { return Res; } +// Handle promotion for the ADDE/SUBE/ADDCARRY/SUBCARRY nodes. Notice that +// the third operand of ADDE/SUBE nodes is carry flag, which differs from +// the ADDCARRY/SUBCARRY nodes in that the third operand is carry Boolean. SDValue DAGTypeLegalizer::PromoteIntRes_ADDSUBCARRY(SDNode *N, unsigned ResNo) { if (ResNo == 1) return PromoteIntRes_Overflow(N); diff --git a/test/CodeGen/PowerPC/pr39815.ll b/test/CodeGen/PowerPC/pr39815.ll new file mode 100644 index 00000000000..a01c8be8634 --- /dev/null +++ b/test/CodeGen/PowerPC/pr39815.ll @@ -0,0 +1,31 @@ +; RUN: llc -mcpu=pwr9 -mtriple=powerpc64le-unknown-linux-gnu < %s \ +; RUN: -verify-machineinstrs | FileCheck %s + +@b = common dso_local local_unnamed_addr global i64* null, align 8 +@a = common dso_local local_unnamed_addr global i8 0, align 1 + +define void @testADDEPromoteResult() { +entry: + %0 = load i64*, i64** @b, align 8 + %1 = load i64, i64* %0, align 8 + %cmp = icmp ne i64* %0, null + %conv1 = zext i1 %cmp to i64 + %add = add nsw i64 %1, %conv1 + %2 = trunc i64 %add to i8 + %conv2 = and i8 %2, 5 + store i8 %conv2, i8* @a, align 1 + ret void + +; CHECK-LABEL: @testADDEPromoteResult +; CHECK: # %bb.0: +; CHECK-DAG: addis [[REG1:[0-9]+]], [[REG2:[0-9]+]], [[VAR1:[a-z0-9A-Z_.]+]]@toc@ha +; CHECK-DAG: ld [[REG3:[0-9]+]], [[VAR1]]@toc@l([[REG1]]) +; CHECK-DAG: lbz [[REG4:[0-9]+]], 0([[REG3]]) +; CHECK-DAG: addic [[REG5:[0-9]+]], [[REG3]], -1 +; CHECK-DAG: extsb [[REG6:[0-9]+]], [[REG4]] +; CHECK-DAG: addze [[REG7:[0-9]+]], [[REG6]] +; CHECK-DAG: addis [[REG8:[0-9]+]], [[REG2]], [[VAR2:[a-z0-9A-Z_.]+]]@toc@ha +; CHECK-DAG: andi. [[REG9:[0-9]+]], [[REG7]], 5 +; CHECK-DAG: stb [[REG9]], [[VAR2]]@toc@l([[REG8]]) +; CHECK: blr +} -- 2.50.1