From db9c42b0dda01628205451a4c2500ee40cd95278 Mon Sep 17 00:00:00 2001 From: Luca Toscano Date: Wed, 18 Apr 2018 10:00:20 +0000 Subject: [PATCH] Update my proposal with jhriggs and jailletc36's suggestions. Reset jhriggs' vote since the patch changed. Thanks to both for the help! git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1829431 13f79535-47bb-0310-9956-ffa450edef68 --- STATUS | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/STATUS b/STATUS index ea8970b24c..9b115bff21 100644 --- a/STATUS +++ b/STATUS @@ -244,16 +244,12 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: 2.4.x patch: svn merge -c 1828920 ^/httpd/httpd/trunk . +1: covener, jhriggs - *) core: use strncmp in check_errorlog_dir when checking if the ErrorLog directive - is configured with the 'syslog' prefix. PR 62102 + *) core: use strncmp in check_errorlog_dir and core_dump_config when checking + if the ErrorLog directive is configured with the 'syslog' prefix. PR 62102 trunk patch: none, as far as I can see the code in trunk diverged too much due to the code in STALLED for ap_errorlog_provider. 2.4.x patch: https://svn.apache.org/repos/asf/httpd/httpd/patches/2.4.x/core-check_errorlog_dir_syslog.patch - +1: elukey, jhriggs - jhriggs: One nit: old code used `strcmp(...) == 0' and trunk uses `strncmp(...) == 0' vs. this - using `!strncmp(...)'. Same result, but consistency is a good thing, one way or the - other. +1 regardless. - jailletc36: the corresponding 'strcmp()' in 'core_dump_config()' should be updated accordingly, IMHO. + +1: elukey PATCHES/ISSUES THAT ARE BEING WORKED [ New entries should be added at the START of the list ] -- 2.40.0