From db546fa2ce65dd2e275fc3fdee961767d53f77cf Mon Sep 17 00:00:00 2001 From: Argyrios Kyrtzidis Date: Fri, 15 Feb 2013 18:34:15 +0000 Subject: [PATCH] Fix crash-on-invalid where a ParenListExpr shows up as a message receiver while trying to do error recovery. rdar://13207886 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@175282 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaExprObjC.cpp | 7 +++++++ test/SemaObjC/message.m | 8 ++++++++ 2 files changed, 15 insertions(+) diff --git a/lib/Sema/SemaExprObjC.cpp b/lib/Sema/SemaExprObjC.cpp index 7f0c832575..76ee983712 100644 --- a/lib/Sema/SemaExprObjC.cpp +++ b/lib/Sema/SemaExprObjC.cpp @@ -2485,6 +2485,13 @@ ExprResult Sema::ActOnInstanceMessage(Scope *S, MultiExprArg Args) { if (!Receiver) return ExprError(); + + // A ParenListExpr can show up while doing error recovery with invalid code. + if (isa(Receiver)) { + ExprResult Result = MaybeConvertParenListExprToParenExpr(S, Receiver); + if (Result.isInvalid()) return ExprError(); + Receiver = Result.take(); + } if (RespondsToSelectorSel.isNull()) { IdentifierInfo *SelectorId = &Context.Idents.get("respondsToSelector"); diff --git a/test/SemaObjC/message.m b/test/SemaObjC/message.m index 621a18fc9b..4015690bd0 100644 --- a/test/SemaObjC/message.m +++ b/test/SemaObjC/message.m @@ -98,3 +98,11 @@ void foo4() { [X rect]; // expected-warning {{receiver type 'struct objc_object *' is not 'id' or interface pointer, consider casting it to 'id'}} expected-warning {{method '-rect' not found (return type defaults to 'id')}} } +// rdar://13207886 +void foo5(id p) { + p + [(id)(p) bar]; // expected-error {{missing '['}} \ + // expected-error {{expected ']'}} \ + // expected-note {{to match this '['}} \ + // expected-warning {{instance method '-bar' not found}} +} -- 2.40.0