From da8c61718359d084e98c78094e00b70c65dd12b7 Mon Sep 17 00:00:00 2001 From: Serge Guelton Date: Tue, 5 Feb 2019 13:01:12 +0000 Subject: [PATCH] gn build: Fix Python 3 write_vcsrevision script compatibility Trivial fix: decode was not called for all subprocess.check_output calls. Commited on behalf of Andrew Boyarshin Differential Revision: https://reviews.llvm.org/D57505 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@353168 91177308-0d34-0410-b5e6-96231b3b80d8 --- utils/gn/build/write_vcsrevision.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/gn/build/write_vcsrevision.py b/utils/gn/build/write_vcsrevision.py index 974004df915..5bdca23e764 100755 --- a/utils/gn/build/write_vcsrevision.py +++ b/utils/gn/build/write_vcsrevision.py @@ -47,7 +47,7 @@ def main(): use_shell = True git_dir = subprocess.check_output([git, 'rev-parse', '--git-dir'], - cwd=LLVM_DIR, shell=use_shell).strip() + cwd=LLVM_DIR, shell=use_shell).decode().strip() if not os.path.isdir(git_dir): print('.git dir not found at "%s"' % git_dir, file=sys.stderr) return 1 -- 2.50.1