From d9d25f2c2740d67d3b6d4106d397ebffb0759d80 Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Sun, 29 May 2016 11:04:56 +0000 Subject: [PATCH] Avoid unnecessary std::string copies. NFC. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@271182 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Frontend/CompilerInvocation.cpp | 2 +- lib/Tooling/Refactoring.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/Frontend/CompilerInvocation.cpp b/lib/Frontend/CompilerInvocation.cpp index 4bb08c8a81..42ce6df132 100644 --- a/lib/Frontend/CompilerInvocation.cpp +++ b/lib/Frontend/CompilerInvocation.cpp @@ -400,7 +400,7 @@ static void setPGOInstrumentor(CodeGenOptions &Opts, ArgList &Args, // Set the profile kind using fprofile-instrument-use-path. static void setPGOUseInstrumentor(CodeGenOptions &Opts, - const std::string ProfileName) { + const Twine &ProfileName) { auto ReaderOrErr = llvm::IndexedInstrProfReader::create(ProfileName); // In error, return silently and let Clang PGOUse report the error message. if (auto E = ReaderOrErr.takeError()) { diff --git a/lib/Tooling/Refactoring.cpp b/lib/Tooling/Refactoring.cpp index 3a15275585..51f0635c1e 100644 --- a/lib/Tooling/Refactoring.cpp +++ b/lib/Tooling/Refactoring.cpp @@ -70,8 +70,8 @@ bool formatAndApplyAllReplacements(const Replacements &Replaces, auto FileToReplaces = groupReplacementsByFile(Replaces); bool Result = true; - for (auto &FileAndReplaces : FileToReplaces) { - const std::string FilePath = FileAndReplaces.first; + for (const auto &FileAndReplaces : FileToReplaces) { + const std::string &FilePath = FileAndReplaces.first; auto &CurReplaces = FileAndReplaces.second; const FileEntry *Entry = Files.getFile(FilePath); -- 2.50.1