From d8effc00b6ad6b83c7c7d2673dfda7a07544f8d8 Mon Sep 17 00:00:00 2001 From: Matthew Fernandez Date: Wed, 11 May 2022 21:42:35 -0700 Subject: [PATCH] gv2gml: remove 'outFile' parameter to 'emitInt' The only calls to this function pass `outFile`, an already available global that this parameter was shadowing. This removes a -Wshadow warning. --- cmd/tools/gv2gml.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/cmd/tools/gv2gml.c b/cmd/tools/gv2gml.c index aef0ef489..f4bb6710e 100644 --- a/cmd/tools/gv2gml.c +++ b/cmd/tools/gv2gml.c @@ -131,9 +131,7 @@ parseStyle (char* s) return flags; } -static void -emitInt (char* name, int value, FILE* outFile, int ix) -{ +static void emitInt(char *name, int value, int ix) { indent (ix, outFile); fprintf (outFile, "%s %d\n", name, value); } @@ -372,10 +370,10 @@ static void emitNodeAttrs(Agraph_t *G, Agnode_t *np, int ix) { emitReal("H", attrs.h, ix+1); } if (attrs.flags & INVIS) { - emitInt ("visible", 0, outFile, ix+1); + emitInt("visible", 0, ix+1); } if (attrs.flags & FILL) { - emitInt ("hasFill", 1, outFile, ix+1); + emitInt("hasFill", 1, ix+1); } if (attrs.type) { emitAttr("type", attrs.type, ix+1); @@ -541,7 +539,7 @@ static void emitEdgeAttrs(Agraph_t *G, Agedge_t *ep, int ix) { emitSpline(attrs.pos, ix+1); } if (attrs.flags & INVIS) { - emitInt ("visible", 0, outFile, ix+1); + emitInt("visible", 0, ix+1); } if (attrs.fill) { emitAttr("fill", attrs.fill, ix+1); -- 2.40.0