From d8a8972ca955202cb895a48f6d78b17c37f1d1ce Mon Sep 17 00:00:00 2001 From: Benjamin Peterson Date: Mon, 18 Aug 2008 16:40:03 +0000 Subject: [PATCH] change threading.getIdent to a property This is new in 2.6 so now need to worry about backwards compatibility :) --- Doc/library/threading.rst | 8 ++++---- Lib/test/test_threading.py | 4 ++-- Lib/threading.py | 3 ++- Misc/NEWS | 2 +- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/Doc/library/threading.rst b/Doc/library/threading.rst index d02b76f47b..1d929faac6 100644 --- a/Doc/library/threading.rst +++ b/Doc/library/threading.rst @@ -661,12 +661,12 @@ impossible to detect the termination of alien threads. constructor. -.. method:: Thread.get_ident() +.. attribute:: Thread.ident - Return the 'thread identifier' of this thread or None if the thread has not - been started. This is a nonzero integer. See the :func:`thread.get_ident()` + The 'thread identifier' of this thread or ``None`` if the thread has not been + started. This is a nonzero integer. See the :func:`thread.get_ident()` function. Thread identifiers may be recycled when a thread exits and another - thread is created. The identifier is returned even after the thread has + thread is created. The identifier is available even after the thread has exited. .. versionadded:: 2.6 diff --git a/Lib/test/test_threading.py b/Lib/test/test_threading.py index 44c3336b0a..7c3d90bdd6 100644 --- a/Lib/test/test_threading.py +++ b/Lib/test/test_threading.py @@ -73,7 +73,7 @@ class ThreadTests(unittest.TestCase): for i in range(NUMTASKS): t = TestThread(""%i, self, sema, mutex, numrunning) threads.append(t) - self.failUnlessEqual(t.get_ident(), None) + self.failUnlessEqual(t.ident, None) self.assert_(re.match('', repr(t))) t.start() @@ -82,7 +82,7 @@ class ThreadTests(unittest.TestCase): for t in threads: t.join(NUMTASKS) self.assert_(not t.is_alive()) - self.failIfEqual(t.get_ident(), 0) + self.failIfEqual(t.ident, 0) self.assert_(re.match('', repr(t))) if verbose: print 'all tasks done' diff --git a/Lib/threading.py b/Lib/threading.py index d88f1be4ea..e1a0b2a73f 100644 --- a/Lib/threading.py +++ b/Lib/threading.py @@ -663,7 +663,8 @@ class Thread(_Verbose): setName = _old_api(set_name, "setName") - def get_ident(self): + @property + def ident(self): assert self.__initialized, "Thread.__init__() not called" return self.__ident diff --git a/Misc/NEWS b/Misc/NEWS index 09f1138689..7a0838e01a 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -422,7 +422,7 @@ Extension Modules - Issue #2870: cmathmodule.c compile error. -- Added a threading.Thread.getIdent() method. +- Added a threading.Thread.ident property. Library ------- -- 2.50.0