From d70cb645702bdbb42aee58403306a7c47e0d901c Mon Sep 17 00:00:00 2001 From: Daniel Dunbar Date: Thu, 16 Oct 2008 06:39:30 +0000 Subject: [PATCH] Simplify overflow-on-add check in NumericLiteralParser::GetIntegerValue. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@57629 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Lex/LiteralSupport.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/Lex/LiteralSupport.cpp b/lib/Lex/LiteralSupport.cpp index f63e6cfffc..1b86ba5def 100644 --- a/lib/Lex/LiteralSupport.cpp +++ b/lib/Lex/LiteralSupport.cpp @@ -481,10 +481,9 @@ bool NumericLiteralParser::GetIntegerValue(llvm::APInt &Val) { Val *= RadixVal; OverflowOccurred |= Val.udiv(RadixVal) != OldVal; - OldVal = Val; // Add value, did overflow occur on the value? + // (a + b) ult b <=> overflow Val += CharVal; - OverflowOccurred |= Val.ult(OldVal); OverflowOccurred |= Val.ult(CharVal); } return OverflowOccurred; -- 2.40.0