From d4d8d486af1810bff52612d84533985b9b47b7a6 Mon Sep 17 00:00:00 2001 From: Sebastian Pipping Date: Wed, 17 Jul 2019 16:21:31 +0200 Subject: [PATCH] xmltok.c: Use memcpy instead of copying single bytes (fixes #282) Fixes cppcheck's complaint as a side-effect. --- expat/lib/xmltok.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/expat/lib/xmltok.c b/expat/lib/xmltok.c index 6b415d83..549ae8db 100644 --- a/expat/lib/xmltok.c +++ b/expat/lib/xmltok.c @@ -1502,8 +1502,7 @@ XmlInitUnknownEncoding(void *mem, { int i; struct unknown_encoding *e = (struct unknown_encoding *)mem; - for (i = 0; i < (int)sizeof(struct normal_encoding); i++) - ((char *)mem)[i] = ((char *)&latin1_encoding)[i]; + memcpy(mem, &latin1_encoding, sizeof(struct normal_encoding)); for (i = 0; i < 128; i++) if (latin1_encoding.type[i] != BT_OTHER && latin1_encoding.type[i] != BT_NONXML -- 2.40.0