From d4b090f54fe8147157485b2c9b7753731e611354 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 1 Jul 2019 19:46:04 -0400 Subject: [PATCH] Revert "Insert temporary debugging output in regression tests." This reverts commit f03a9ca4366d064d89b7cf7ed75d4e43f2ed0667, in the v12 branch only. We don't want to ship v12 with that, since it causes occasional test failures (as a result of statistics transmission not being entirely reliable). I'll leave it in HEAD though, in hopes that we'll eventually capture an instance of the original problematic behavior. --- src/test/regress/expected/select_parallel.out | 27 ------------------- src/test/regress/expected/stats.out | 27 ------------------- src/test/regress/sql/select_parallel.sql | 8 ------ src/test/regress/sql/stats.sql | 8 ------ 4 files changed, 70 deletions(-) diff --git a/src/test/regress/expected/select_parallel.out b/src/test/regress/expected/select_parallel.out index 9775cc898c..0eca76cb41 100644 --- a/src/test/regress/expected/select_parallel.out +++ b/src/test/regress/expected/select_parallel.out @@ -89,33 +89,6 @@ select round(avg(aa)), sum(aa) from a_star a3; 14 | 355 (1 row) --- Temporary hack to investigate whether extra vacuum/analyze is happening -select relname, relpages, reltuples -from pg_class -where relname like '__star' order by relname; - relname | relpages | reltuples ----------+----------+----------- - a_star | 1 | 3 - b_star | 1 | 4 - c_star | 1 | 4 - d_star | 1 | 16 - e_star | 1 | 7 - f_star | 1 | 16 -(6 rows) - -select relname, vacuum_count, analyze_count, autovacuum_count, autoanalyze_count -from pg_stat_all_tables -where relname like '__star' order by relname; - relname | vacuum_count | analyze_count | autovacuum_count | autoanalyze_count ----------+--------------+---------------+------------------+------------------- - a_star | 1 | 0 | 0 | 0 - b_star | 1 | 0 | 0 | 0 - c_star | 1 | 0 | 0 | 0 - d_star | 1 | 0 | 0 | 0 - e_star | 1 | 0 | 0 | 0 - f_star | 1 | 0 | 0 | 0 -(6 rows) - -- Disable Parallel Append alter table a_star reset (parallel_workers); alter table b_star reset (parallel_workers); diff --git a/src/test/regress/expected/stats.out b/src/test/regress/expected/stats.out index 61fbf7e41e..b01e58b98c 100644 --- a/src/test/regress/expected/stats.out +++ b/src/test/regress/expected/stats.out @@ -199,33 +199,6 @@ FROM prevstats AS pr; t (1 row) --- Temporary hack to investigate whether extra vacuum/analyze is happening -select relname, relpages, reltuples -from pg_class -where relname like '__star' order by relname; - relname | relpages | reltuples ----------+----------+----------- - a_star | 1 | 3 - b_star | 1 | 4 - c_star | 1 | 4 - d_star | 1 | 16 - e_star | 1 | 7 - f_star | 1 | 16 -(6 rows) - -select relname, vacuum_count, analyze_count, autovacuum_count, autoanalyze_count -from pg_stat_all_tables -where relname like '__star' order by relname; - relname | vacuum_count | analyze_count | autovacuum_count | autoanalyze_count ----------+--------------+---------------+------------------+------------------- - a_star | 1 | 0 | 0 | 0 - b_star | 1 | 0 | 0 | 0 - c_star | 1 | 0 | 0 | 0 - d_star | 1 | 0 | 0 | 0 - e_star | 1 | 0 | 0 | 0 - f_star | 1 | 0 | 0 | 0 -(6 rows) - DROP TABLE trunc_stats_test, trunc_stats_test1, trunc_stats_test2, trunc_stats_test3, trunc_stats_test4; DROP TABLE prevstats; -- End of Stats Test diff --git a/src/test/regress/sql/select_parallel.sql b/src/test/regress/sql/select_parallel.sql index f96812b550..03c056b8b7 100644 --- a/src/test/regress/sql/select_parallel.sql +++ b/src/test/regress/sql/select_parallel.sql @@ -36,14 +36,6 @@ explain (costs off) select round(avg(aa)), sum(aa) from a_star; select round(avg(aa)), sum(aa) from a_star a3; --- Temporary hack to investigate whether extra vacuum/analyze is happening -select relname, relpages, reltuples -from pg_class -where relname like '__star' order by relname; -select relname, vacuum_count, analyze_count, autovacuum_count, autoanalyze_count -from pg_stat_all_tables -where relname like '__star' order by relname; - -- Disable Parallel Append alter table a_star reset (parallel_workers); alter table b_star reset (parallel_workers); diff --git a/src/test/regress/sql/stats.sql b/src/test/regress/sql/stats.sql index 9defd4b7a9..feaaee6326 100644 --- a/src/test/regress/sql/stats.sql +++ b/src/test/regress/sql/stats.sql @@ -174,14 +174,6 @@ SELECT st.heap_blks_read + st.heap_blks_hit >= pr.heap_blks + cl.relpages, SELECT pr.snap_ts < pg_stat_get_snapshot_timestamp() as snapshot_newer FROM prevstats AS pr; --- Temporary hack to investigate whether extra vacuum/analyze is happening -select relname, relpages, reltuples -from pg_class -where relname like '__star' order by relname; -select relname, vacuum_count, analyze_count, autovacuum_count, autoanalyze_count -from pg_stat_all_tables -where relname like '__star' order by relname; - DROP TABLE trunc_stats_test, trunc_stats_test1, trunc_stats_test2, trunc_stats_test3, trunc_stats_test4; DROP TABLE prevstats; -- End of Stats Test -- 2.40.0