From d44335b4f8a41fb0e6c0176be7c3c53d65d1cc0f Mon Sep 17 00:00:00 2001 From: Pieter Lexis Date: Mon, 11 Mar 2019 17:20:05 +0100 Subject: [PATCH] Don't clobber C{,XX}FLAGS when set in env --- configure.ac | 5 +++-- pdns/dnsdistdist/configure.ac | 6 +++++- pdns/recursordist/configure.ac | 5 +++-- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 6325b0690..8ac60b12c 100644 --- a/configure.ac +++ b/configure.ac @@ -17,8 +17,9 @@ AM_INIT_AUTOMAKE([foreign dist-bzip2 no-dist-gzip tar-ustar -Wno-portability sub AM_SILENT_RULES([yes]) AC_CANONICAL_HOST -: ${CFLAGS="-Wall -g -O2"} -: ${CXXFLAGS="-Wall -g -O2"} +# Add some default CFLAGS and CXXFLAGS, can be appended to using the environment variables +CFLAGS="-Wall -g -O2 $CFLAGS" +CXXFLAGS="-Wall -g -O2 $CXXFLAGS" AC_PROG_CC AM_PROG_CC_C_O diff --git a/pdns/dnsdistdist/configure.ac b/pdns/dnsdistdist/configure.ac index e28decf08..1013e0d43 100644 --- a/pdns/dnsdistdist/configure.ac +++ b/pdns/dnsdistdist/configure.ac @@ -17,6 +17,9 @@ AC_DEFINE([DNSDIST], [1], LT_PREREQ([2.2.2]) LT_INIT([disable-static]) +CFLAGS="-Wall -g -O3 $CFLAGS" +CXXFLAGS="-Wall -g -O3 $CXXFLAGS" + PDNS_WITH_LIBSODIUM PDNS_CHECK_DNSTAP PDNS_CHECK_RAGEL([dnslabeltext.cc], [www.dnsdist.org]) @@ -93,11 +96,12 @@ LDFLAGS="$RELRO_LDFLAGS $LDFLAGS" CFLAGS="$PIE_CFLAGS $CFLAGS" CXXFLAGS="$PIE_CFLAGS $CXXFLAGS" + PROGRAM_LDFLAGS="$PIE_LDFLAGS $PROGRAM_LDFLAGS" AC_SUBST([PROGRAM_LDFLAGS]) AC_SUBST([AM_CPPFLAGS], - ["AS_ESCAPE([-I$(top_builddir) -I$(top_srcdir)]) -Wall -O3 -pthread $BOOST_CPPFLAGS"] + ["AS_ESCAPE([-I$(top_builddir) -I$(top_srcdir)]) $THREADFLAGS $BOOST_CPPFLAGS"] ) AC_ARG_VAR(PACKAGEVERSION, [The version used in secpoll queries]) diff --git a/pdns/recursordist/configure.ac b/pdns/recursordist/configure.ac index ce066fb7a..70aeaa2c6 100644 --- a/pdns/recursordist/configure.ac +++ b/pdns/recursordist/configure.ac @@ -10,8 +10,9 @@ AC_CONFIG_MACRO_DIR([m4]) AC_CONFIG_HEADERS([config.h]) AC_CANONICAL_HOST -: ${CFLAGS="-Wall -g -O2"} -: ${CXXFLAGS="-Wall -g -O2"} +# Add some default CFLAGS and CXXFLAGS, can be appended to using the environment variables +CFLAGS="-Wall -g -O2 $CFLAGS" +CXXFLAGS="-Wall -g -O2 $CXXFLAGS" AC_SUBST([pdns_configure_args],["$ac_configure_args"]) AC_DEFINE_UNQUOTED([PDNS_CONFIG_ARGS], -- 2.40.0