From d43399189773cfc9c9b52a924f34ed3cb9339dfe Mon Sep 17 00:00:00 2001 From: Kirill Bobyrev Date: Wed, 2 Nov 2016 10:00:40 +0000 Subject: [PATCH] [llvm] FIx if-clause -Wmisleading-indentation issue. While bootstrapping Clang with recent `gcc 6.2.0` I found a bug related to misleading indentation. I believe, a pair of `{}` was forgotten, especially given the above similar piece of code: ``` if (!RDef || !HII->isPredicable(*RDef)) { Done = coalesceRegisters(RD, RegisterRef(S1)); if (Done) { UpdRegs.insert(RD.Reg); UpdRegs.insert(S1.getReg()); } } ``` Reviewers: kparzysz Differential Revision: https://reviews.llvm.org/D26204 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@285794 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/Hexagon/HexagonExpandCondsets.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/Target/Hexagon/HexagonExpandCondsets.cpp b/lib/Target/Hexagon/HexagonExpandCondsets.cpp index 2760e16bd0f..15ffa1c4c66 100644 --- a/lib/Target/Hexagon/HexagonExpandCondsets.cpp +++ b/lib/Target/Hexagon/HexagonExpandCondsets.cpp @@ -1174,12 +1174,13 @@ bool HexagonExpandCondsets::coalesceSegments( if (!Done && S2.isReg()) { RegisterRef RS = S2; MachineInstr *RDef = getReachingDefForPred(RS, CI, RP.Reg, false); - if (!RDef || !HII->isPredicable(*RDef)) + if (!RDef || !HII->isPredicable(*RDef)) { Done = coalesceRegisters(RD, RegisterRef(S2)); if (Done) { UpdRegs.insert(RD.Reg); UpdRegs.insert(S2.getReg()); } + } } Changed |= Done; } -- 2.40.0