From d42066343b3bda72362178e7ece78b9afb709e17 Mon Sep 17 00:00:00 2001 From: Douglas Gregor Date: Fri, 6 Aug 2010 14:50:36 +0000 Subject: [PATCH] The pre-increment/pre-decrement grammar in C++ differs from that in C, but we were parsing the C grammar. Handle the C++ grammar appropriately. Fixes PR7794. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@110445 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Parse/ParseExpr.cpp | 12 ++++++++---- ...rement-qualifiers.cpp => increment-decrement.cpp} | 5 +++++ 2 files changed, 13 insertions(+), 4 deletions(-) rename test/SemaCXX/{inc-decrement-qualifiers.cpp => increment-decrement.cpp} (84%) diff --git a/lib/Parse/ParseExpr.cpp b/lib/Parse/ParseExpr.cpp index 589bf4a35f..ec92f0869e 100644 --- a/lib/Parse/ParseExpr.cpp +++ b/lib/Parse/ParseExpr.cpp @@ -568,7 +568,7 @@ Parser::OwningExprResult Parser::ParseCastExpression(bool isUnaryExpression, // If this expression is limited to being a unary-expression, the parent can // not start a cast expression. ParenParseOption ParenExprType = - isUnaryExpression ? CompoundLiteral : CastExpr; + (isUnaryExpression && !getLang().CPlusPlus)? CompoundLiteral : CastExpr; TypeTy *CastTy; SourceLocation LParenLoc = Tok.getLocation(); SourceLocation RParenLoc; @@ -702,10 +702,14 @@ Parser::OwningExprResult Parser::ParseCastExpression(bool isUnaryExpression, case tok::kw___null: return Actions.ActOnGNUNullExpr(ConsumeToken()); break; - case tok::plusplus: // unary-expression: '++' unary-expression - case tok::minusminus: { // unary-expression: '--' unary-expression + case tok::plusplus: // unary-expression: '++' unary-expression [C99] + case tok::minusminus: { // unary-expression: '--' unary-expression [C99] + // C++ [expr.unary] has: + // unary-expression: + // ++ cast-expression + // -- cast-expression SourceLocation SavedLoc = ConsumeToken(); - Res = ParseCastExpression(true); + Res = ParseCastExpression(!getLang().CPlusPlus); if (!Res.isInvalid()) Res = Actions.ActOnUnaryOp(getCurScope(), SavedLoc, SavedKind, move(Res)); return move(Res); diff --git a/test/SemaCXX/inc-decrement-qualifiers.cpp b/test/SemaCXX/increment-decrement.cpp similarity index 84% rename from test/SemaCXX/inc-decrement-qualifiers.cpp rename to test/SemaCXX/increment-decrement.cpp index ba837a9c06..11b7d1e12f 100644 --- a/test/SemaCXX/inc-decrement-qualifiers.cpp +++ b/test/SemaCXX/increment-decrement.cpp @@ -7,3 +7,8 @@ const int &dec = i--; const int &incfail = ++i; // expected-error {{drops qualifiers}} const int &decfail = --i; // expected-error {{drops qualifiers}} + +// PR7794 +void f0(int e) { + ++(int&)e; +} -- 2.40.0