From d39d23e610c2a7815515d60c5a538d65d05e8bdc Mon Sep 17 00:00:00 2001 From: Richard Smith Date: Thu, 3 May 2012 17:56:49 +0000 Subject: [PATCH] Fix a couple of cases of (innocuous) unmarked fallthrough. At least one of these was unintentional. Found by -Wimplicit-fallthrough, patch by Alexander Kornienko! git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156082 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/clang/AST/RecursiveASTVisitor.h | 1 + include/clang/Analysis/Analyses/FormatString.h | 1 + 2 files changed, 2 insertions(+) diff --git a/include/clang/AST/RecursiveASTVisitor.h b/include/clang/AST/RecursiveASTVisitor.h index 8a6e85f226..a9a98d77ba 100644 --- a/include/clang/AST/RecursiveASTVisitor.h +++ b/include/clang/AST/RecursiveASTVisitor.h @@ -1400,6 +1400,7 @@ bool RecursiveASTVisitor::TraverseClassInstantiations( case TSK_Undeclared: case TSK_ImplicitInstantiation: TRY_TO(TraverseDecl(SD)); + break; // We don't need to do anything on an explicit instantiation // or explicit specialization because there will be an explicit diff --git a/include/clang/Analysis/Analyses/FormatString.h b/include/clang/Analysis/Analyses/FormatString.h index 9ec27ce91d..f99b97a189 100644 --- a/include/clang/Analysis/Analyses/FormatString.h +++ b/include/clang/Analysis/Analyses/FormatString.h @@ -175,6 +175,7 @@ public: switch (kind) { case PrintErrno: assert(IsPrintf); + return false; case PercentArg: return false; default: -- 2.40.0