From ce0afc0b09accbf7370b2ba87574b2c4be7fb032 Mon Sep 17 00:00:00 2001
From: Chris Lattner <sabre@nondot.org>
Date: Wed, 18 Jul 2007 05:21:20 +0000
Subject: [PATCH] add a note Neil pointed out

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@39994 91177308-0d34-0410-b5e6-96231b3b80d8
---
 AST/Expr.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/AST/Expr.cpp b/AST/Expr.cpp
index 7b8e1fdf5e..17f474c194 100644
--- a/AST/Expr.cpp
+++ b/AST/Expr.cpp
@@ -277,6 +277,10 @@ Expr::isModifiableLvalueResult Expr::isModifiableLvalue() const {
 ///
 /// FIXME: This should ext-warn on overflow during evaluation!  ISO C does not
 /// permit this.
+///
+/// FIXME: Handle offsetof.  Two things to do:  Handle GCC's __builtin_offsetof
+/// to support gcc 4.0+  and handle the idiom GCC recognizes with a null pointer
+/// cast+dereference.
 bool Expr::isIntegerConstantExpr(llvm::APSInt &Result, ASTContext &Ctx,
                                  SourceLocation *Loc, bool isEvaluated) const {
   switch (getStmtClass()) {
-- 
2.50.1