From cd858fe243698a5208d38104cfe957f57a393a76 Mon Sep 17 00:00:00 2001 From: Antony Dovgal Date: Fri, 29 Feb 2008 13:56:46 +0000 Subject: [PATCH] fix segfault, comment out useless line --- ext/phar/tar.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ext/phar/tar.c b/ext/phar/tar.c index 5c1d19c356..f7f8dba3cd 100644 --- a/ext/phar/tar.c +++ b/ext/phar/tar.c @@ -121,6 +121,10 @@ int phar_open_or_create_tar(char *fname, int fname_len, char *alias, int alias_l phar_archive_data *phar; int ret = phar_create_or_parse_filename(fname, fname_len, alias, alias_len, options, &phar, error TSRMLS_CC); + if (FAILURE == ret) { + return FAILURE; + } + if (pphar) { *pphar = phar; } @@ -128,15 +132,11 @@ int phar_open_or_create_tar(char *fname, int fname_len, char *alias, int alias_l phar->is_data = is_data; if (is_data) { - phar->is_writeable; + /* phar->is_writeable; WTF */ phar->alias = NULL; phar->alias_len = 0; } - if (FAILURE == ret) { - return FAILURE; - } - if (phar->is_tar) { return ret; } -- 2.50.1