From cad9f41b3e82df62910832273f900f8252530d4f Mon Sep 17 00:00:00 2001 From: Ted Kremenek Date: Fri, 24 Jul 2009 20:26:31 +0000 Subject: [PATCH] In the "use of floating point variable as loop counter" check, check if the DeclRefExpr is a float, not just either argument. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@76998 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Analysis/CheckSecuritySyntaxOnly.cpp | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lib/Analysis/CheckSecuritySyntaxOnly.cpp b/lib/Analysis/CheckSecuritySyntaxOnly.cpp index 5c98a526b7..17fc6d7c32 100644 --- a/lib/Analysis/CheckSecuritySyntaxOnly.cpp +++ b/lib/Analysis/CheckSecuritySyntaxOnly.cpp @@ -143,16 +143,18 @@ void WalkAST::CheckLoopConditionForFloat(const ForStmt *FS) { if (!B) return; - // The actual error condition. - if (!((B->isRelationalOp() || B->isEqualityOp()) && - ((B->getLHS()->getType()->isFloatingType() || - B->getRHS()->getType()->isFloatingType())))) + // Is this a comparison? + if (!(B->isRelationalOp() || B->isEqualityOp())) return; - + // Are we comparing variables? const DeclRefExpr *drLHS = dyn_cast(B->getLHS()->IgnoreParens()); const DeclRefExpr *drRHS = dyn_cast(B->getRHS()->IgnoreParens()); + // Does at least one of the variables have a floating point type? + drLHS = drLHS && drLHS->getType()->isFloatingType() ? drLHS : NULL; + drRHS = drRHS && drRHS->getType()->isFloatingType() ? drRHS : NULL; + if (!drLHS && !drRHS) return; -- 2.40.0