From ca5bbb310e662b516ee943c29df782e11404f576 Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Mon, 18 Mar 2019 21:21:12 +0000 Subject: [PATCH] [WebAssembly] Don't override default implementation of isOffsetFoldingLegal. NFC. The default implementation does we want and is going to more compatible with dynamic linking (-fPIC) support that is planned. This is NFC because currently we only build wasm with `-relocation-model=static` which in turn means that the default `isOffsetFoldingLegal` always returns true today. Differential Revision: https://reviews.llvm.org/D54661 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@356410 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/TargetMachine.cpp | 2 +- lib/Target/WebAssembly/WebAssemblyISelLowering.cpp | 6 ------ lib/Target/WebAssembly/WebAssemblyISelLowering.h | 1 - 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/lib/Target/TargetMachine.cpp b/lib/Target/TargetMachine.cpp index c08ed43fe6b..7a1e01bdab6 100644 --- a/lib/Target/TargetMachine.cpp +++ b/lib/Target/TargetMachine.cpp @@ -161,7 +161,7 @@ bool TargetMachine::shouldAssumeDSOLocal(const Module &M, if (GV && !GV->hasDefaultVisibility()) return true; - if (TT.isOSBinFormatMachO()) { + if (TT.isOSBinFormatMachO() || TT.isOSBinFormatWasm()) { if (RM == Reloc::Static) return true; return GV && GV->isStrongDefinitionForLinker(); diff --git a/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp b/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp index 9f81da01f90..aa7bba8b17d 100644 --- a/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp +++ b/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp @@ -294,12 +294,6 @@ FastISel *WebAssemblyTargetLowering::createFastISel( return WebAssembly::createFastISel(FuncInfo, LibInfo); } -bool WebAssemblyTargetLowering::isOffsetFoldingLegal( - const GlobalAddressSDNode * /*GA*/) const { - // All offsets can be folded. - return true; -} - MVT WebAssemblyTargetLowering::getScalarShiftAmountTy(const DataLayout & /*DL*/, EVT VT) const { unsigned BitWidth = NextPowerOf2(VT.getSizeInBits() - 1); diff --git a/lib/Target/WebAssembly/WebAssemblyISelLowering.h b/lib/Target/WebAssembly/WebAssemblyISelLowering.h index ee2e863685a..81e85fc8a0c 100644 --- a/lib/Target/WebAssembly/WebAssemblyISelLowering.h +++ b/lib/Target/WebAssembly/WebAssemblyISelLowering.h @@ -46,7 +46,6 @@ private: AtomicExpansionKind shouldExpandAtomicRMWInIR(AtomicRMWInst *) const override; FastISel *createFastISel(FunctionLoweringInfo &FuncInfo, const TargetLibraryInfo *LibInfo) const override; - bool isOffsetFoldingLegal(const GlobalAddressSDNode *GA) const override; MVT getScalarShiftAmountTy(const DataLayout &DL, EVT) const override; MachineBasicBlock * EmitInstrWithCustomInserter(MachineInstr &MI, -- 2.40.0