From c959e01a05046bf48f90c842252dc67fbc9119f6 Mon Sep 17 00:00:00 2001
From: Seth Ornstein <sornstein@globalcyberalliance.org>
Date: Fri, 28 Jul 2017 19:04:44 -0400
Subject: [PATCH] fixed 3 of the "nits" flagged by Remi

---
 pdns/dnsdist.hh  | 4 ++--
 pdns/protobuf.cc | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/pdns/dnsdist.hh b/pdns/dnsdist.hh
index cbd3ebdd9..1763c060a 100644
--- a/pdns/dnsdist.hh
+++ b/pdns/dnsdist.hh
@@ -68,7 +68,7 @@ QTag()
 {
 }
 
-void add(std::string strLabel, std::string strValue)
+void add(const std::string strLabel, const std::string strValue)
 {
   tagData.insert( {strLabel, strValue});
   return;
@@ -126,7 +126,7 @@ public:
   std::unordered_map<std::string, std::string>tagData;
 
 private:
-  const char *strSep = "\t";
+  static constexpr char const *strSep = "\t";
 };
 
 
diff --git a/pdns/protobuf.cc b/pdns/protobuf.cc
index a2acc254b..6cf8e826a 100644
--- a/pdns/protobuf.cc
+++ b/pdns/protobuf.cc
@@ -123,7 +123,7 @@ void DNSProtoBufMessage::addRR(const std::string& strName, uint16_t uType, uint1
     rr->set_type(uType);
     rr->set_class_(uClass);
     rr->set_ttl(uTTL);
-    rr->set_rdata((const uint8_t *) strBlob.c_str(), strBlob.size());
+    rr->set_rdata(strBlob.c_str(), strBlob.size());
   }
 
 #endif /* HAVE_PROTOBUF */
-- 
2.40.0