From c916377785b917e369b8ec9e9af43a4bb6c4699c Mon Sep 17 00:00:00 2001 From: Chandler Carruth Date: Tue, 4 Oct 2011 09:58:21 +0000 Subject: [PATCH] Add a comment explaining that I have a better plan for implementing the GCC installation search that requires fewer filesystem operations. Planning to implement that next as the current approcah while thorough (and so far looks correct) does a very unfortunate number of filesystem operations. I'm motivated to fix this in no small part because I would like to support a much larger space of triples and GCC versions, which would explode the current algorithm. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@141073 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Driver/ToolChains.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/Driver/ToolChains.cpp b/lib/Driver/ToolChains.cpp index dd84992a9c..b67f001e78 100644 --- a/lib/Driver/ToolChains.cpp +++ b/lib/Driver/ToolChains.cpp @@ -1605,6 +1605,8 @@ public: // accuracy, and architecture specificity in that order. The inverted walk // requires testing the filesystem more times than is ideal, but shouldn't // matter in practice as this is once on startup. + // FIXME: Instead of this, we should walk from the root down through each + // layer, and if it is "better" than prior installations found, use it. static const char* GccVersions[] = { "4.6.1", "4.6.0", "4.6", "4.5.3", "4.5.2", "4.5.1", "4.5", -- 2.50.1