From c8ff3421a0531a596e7761d50062c3e270c11535 Mon Sep 17 00:00:00 2001 From: Dmitry Stogov Date: Thu, 28 Aug 2014 20:51:22 +0400 Subject: [PATCH] Duplicate array only if neccessary --- ext/standard/array.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ext/standard/array.c b/ext/standard/array.c index 81ecfd74f1..09aaddfbf5 100644 --- a/ext/standard/array.c +++ b/ext/standard/array.c @@ -1365,11 +1365,14 @@ PHP_FUNCTION(extract) int extract_refs = 0; zend_array *symbol_table; - if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "a/|lz/", &var_array, &extract_type, &prefix) == FAILURE) { + if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "a|lz/", &var_array, &extract_type, &prefix) == FAILURE) { return; } extract_refs = (extract_type & EXTR_REFS); + if (extract_refs) { + SEPARATE_ZVAL(var_array); + } extract_type &= 0xff; if (extract_type < EXTR_OVERWRITE || extract_type > EXTR_IF_EXISTS) { -- 2.50.1