From c8cd2571b9de64d3ac4c5ec8082821bf13f0e6b9 Mon Sep 17 00:00:00 2001 From: Matthew Fernandez Date: Sun, 20 Jun 2021 13:07:10 -0700 Subject: [PATCH] =?utf8?q?CMake:=20when=20finding=20Bison,=20require=20?= =?utf8?q?=E2=89=A53.0?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Commit 4a13c9598ad3d950a251e5d3e5be8d05c59c6214 made the minimum Bison baseline 3.0. This change teaches CMake ths constraint, so using a version of Bison <3.0 now results in a clearer error during configuration rather than a cryptic failure during build. Closes #1916. --- CHANGELOG.md | 2 ++ CMakeLists.txt | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fa3350aa8..12315eef1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - updated Graphviz bug report URL in the Autotools build system - Fix `WIN32` path of `gvc.def` specified in `libgvc_la_LDFLAGS` +- the CMake build system now not only checks for Bison, but also ensures the + found version is recent enough #1916 ### Fixed diff --git a/CMakeLists.txt b/CMakeLists.txt index 90c0ca52c..bd8a27d5b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -42,7 +42,7 @@ list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake") # ============================= Build dependencies ============================= find_package(AWK REQUIRED) -find_package(BISON REQUIRED) +find_package(BISON 3.0 REQUIRED) find_package(FLEX REQUIRED) find_package(Git REQUIRED) -- 2.40.0