From c88b60729e982b3767935c275142d59721e56f7f Mon Sep 17 00:00:00 2001 From: Matthew Fernandez Date: Sat, 5 Mar 2022 13:14:59 -0800 Subject: [PATCH] CI: remove metrics collection in Pylint job The Pylint job was running two checks: 1. Everything, with warning count piped to metrics.txt 2. Everything except the check for FIXMEs, hard failing if there is any warning The latter passes. That is, all Graphviz Python code is warning-free with the exception of FIXMEs. Meanwhile FIXMEs are frequently _intentionally_ introduced in test code, indicating a known open bug for which a test case is being added. So metric collection in step 1 above is not relevant; we expect this number often to go up. This commit removes the collection of this unused metric to decrease CI complexity. --- .gitlab-ci.yml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 2ee2ee782..d9eb95943 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1502,14 +1502,6 @@ lint_pylint: needs: - docker_build_ubuntu-21.10 script: - - logfile=`mktemp` - - python3 -m pylint --rcfile=.pylintrc `find . -name '*.py' | xargs` --exit-zero |& tee $logfile - - echo "$CI_JOB_NAME-warnings `egrep -c '\<[CRWEF][[:digit:]]{4}\>' $logfile`" | tee metrics.txt - python3 -m pylint --rcfile=.pylintrc --disable=fixme `find . -name '*.py' | xargs` - artifacts: - when: on_success - expire_in: 1 week - reports: - metrics: metrics.txt except: - tags -- 2.40.0