From c6ad6fa2478752a069ff857d2b36c81c2a5a3bd4 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Mon, 20 Mar 2017 21:34:19 +0000 Subject: [PATCH] Make implementation details in DwarfExpression protected. (NFC) git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@298308 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/AsmPrinter/DwarfExpression.h | 25 ++++++++++++------------ 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/lib/CodeGen/AsmPrinter/DwarfExpression.h b/lib/CodeGen/AsmPrinter/DwarfExpression.h index 9c5925ece18..fde2be635b2 100644 --- a/lib/CodeGen/AsmPrinter/DwarfExpression.h +++ b/lib/CodeGen/AsmPrinter/DwarfExpression.h @@ -102,13 +102,6 @@ protected: /// Add masking operations to stencil out a subregister. void maskSubRegister(); -public: - DwarfExpression(unsigned DwarfVersion) : DwarfVersion(DwarfVersion) {} - virtual ~DwarfExpression() {}; - - /// This needs to be called last to commit any pending changes. - void finalize(); - /// Output a dwarf operand and an optional assembler comment. virtual void emitOp(uint8_t Op, const char *Comment = nullptr) = 0; /// Emit a raw signed value. @@ -147,6 +140,13 @@ public: /// expression. See PR21176 for more details. void addStackValue(); +public: + DwarfExpression(unsigned DwarfVersion) : DwarfVersion(DwarfVersion) {} + virtual ~DwarfExpression() {}; + + /// This needs to be called last to commit any pending changes. + void finalize(); + /// Emit an indirect dwarf register operation for the given machine register. /// \return false if no DWARF register exists for MachineReg. bool addMachineRegIndirect(const TargetRegisterInfo &TRI, unsigned MachineReg, @@ -206,15 +206,14 @@ public: class DebugLocDwarfExpression : public DwarfExpression { ByteStreamer &BS; -public: - DebugLocDwarfExpression(unsigned DwarfVersion, ByteStreamer &BS) - : DwarfExpression(DwarfVersion), BS(BS) {} - void emitOp(uint8_t Op, const char *Comment = nullptr) override; void emitSigned(int64_t Value) override; void emitUnsigned(uint64_t Value) override; bool isFrameRegister(const TargetRegisterInfo &TRI, unsigned MachineReg) override; +public: + DebugLocDwarfExpression(unsigned DwarfVersion, ByteStreamer &BS) + : DwarfExpression(DwarfVersion), BS(BS) {} }; /// DwarfExpression implementation for singular DW_AT_location. @@ -223,13 +222,13 @@ const AsmPrinter ≈ DwarfUnit &DU; DIELoc ¨ -public: - DIEDwarfExpression(const AsmPrinter &AP, DwarfUnit &DU, DIELoc &DIE); void emitOp(uint8_t Op, const char *Comment = nullptr) override; void emitSigned(int64_t Value) override; void emitUnsigned(uint64_t Value) override; bool isFrameRegister(const TargetRegisterInfo &TRI, unsigned MachineReg) override; +public: + DIEDwarfExpression(const AsmPrinter &AP, DwarfUnit &DU, DIELoc &DIE); DIELoc *finalize() { DwarfExpression::finalize(); return ¨ -- 2.50.1