From c5e6e7acba790439da565923797f426278bc73df Mon Sep 17 00:00:00 2001 From: Sami Kerola Date: Sat, 24 Nov 2012 10:45:14 +0000 Subject: [PATCH] assingments: remove initialization if value is never used The next operation with these variables will overwrite the values set at init. Signed-off-by: Sami Kerola --- src/database.c | 2 +- src/pw_dup.c | 2 +- src/security.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/database.c b/src/database.c index 1cf113a..0bb305c 100644 --- a/src/database.c +++ b/src/database.c @@ -281,7 +281,7 @@ void check_inotify_database(cron_db * old_db) { DIR *dir; struct timeval time; fd_set rfds; - int retval = 0; + int retval; char buf[BUF_LEN]; pid_t pid = getpid(); time.tv_sec = 0; diff --git a/src/pw_dup.c b/src/pw_dup.c index 519dc75..23da57e 100644 --- a/src/pw_dup.c +++ b/src/pw_dup.c @@ -43,7 +43,7 @@ struct passwd * pw_dup(const struct passwd *pw) { char *cp; - size_t nsize=0, psize=0, gsize=0, dsize=0, ssize=0, total=0; + size_t nsize=0, psize=0, gsize=0, dsize=0, ssize=0, total; struct passwd *newpw; /* Allocate in one big chunk for easy freeing */ diff --git a/src/security.c b/src/security.c index 83c7d7e..6418258 100644 --- a/src/security.c +++ b/src/security.c @@ -596,7 +596,7 @@ int crontab_security_access(void) { */ static char **build_env(char **cronenv) { #ifdef WITH_PAM - char **jobenv = cronenv; + char **jobenv; char **pamenv = pam_getenvlist(pamh); char *cronvar; int count = 0; -- 2.40.0