From c591936789f4979c7e3f20eeacfebc6c3a7886bf Mon Sep 17 00:00:00 2001 From: Benjamin Peterson Date: Sat, 14 Nov 2015 15:12:18 -0800 Subject: [PATCH] fix possible memory lea k in _get_aia_uri (closes #25578) --- Misc/NEWS | 2 ++ Modules/_ssl.c | 5 ++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/Misc/NEWS b/Misc/NEWS index 5d30b1a5e2..ec443917c7 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -55,6 +55,8 @@ Core and Builtins Library ------- +- Issue #25578: Fix (another) memory leak in SSLSocket.getpeercer(). + - Issue #25590: In the Readline completer, only call getattr() once per attribute. diff --git a/Modules/_ssl.c b/Modules/_ssl.c index c9c556e832..55159d7de1 100644 --- a/Modules/_ssl.c +++ b/Modules/_ssl.c @@ -965,7 +965,10 @@ _get_aia_uri(X509 *certificate, int nid) { AUTHORITY_INFO_ACCESS *info; info = X509_get_ext_d2i(certificate, NID_info_access, NULL, NULL); - if ((info == NULL) || (sk_ACCESS_DESCRIPTION_num(info) == 0)) { + if (info == NULL) + return Py_None; + if (sk_ACCESS_DESCRIPTION_num(info) == 0) { + AUTHORITY_INFO_ACCESS_free(info); return Py_None; } -- 2.50.1