From c3828075598ca775555b29b78e67d3fa8e856c00 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Tue, 29 Jul 2014 00:04:54 +0200 Subject: [PATCH] Issue #19612: subprocess.communicate() now also ignores EINVAL when using at least two pipes. --- Lib/subprocess.py | 10 +++++++++- Misc/NEWS | 3 +++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/Lib/subprocess.py b/Lib/subprocess.py index ce47b5e9ad..f9e9104d45 100644 --- a/Lib/subprocess.py +++ b/Lib/subprocess.py @@ -1035,7 +1035,15 @@ class Popen(object): try: self.stdin.write(input) except IOError as e: - if e.errno != errno.EPIPE: + if e.errno == errno.EPIPE: + # communicate() should ignore broken pipe error + pass + elif (e.errno == errno.EINVAL + and self.poll() is not None): + # Issue #19612: stdin.write() fails with EINVAL + # if the process already exited before the write + pass + else: raise self.stdin.close() diff --git a/Misc/NEWS b/Misc/NEWS index f2087c5c5c..bdd414ebeb 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -13,6 +13,9 @@ Core and Builtins Library ------- +- Issue #19612: subprocess.communicate() now also ignores EINVAL when using at + least two pipes. + - Fix repr(_socket.socket) on Windows 64-bit: don't fail with OverflowError on closed socket. -- 2.50.1