From c3495d5dc0569b5b024be1e50f357b1b97c76d12 Mon Sep 17 00:00:00 2001 From: Xinchen Hui Date: Sat, 28 May 2016 15:15:53 +0800 Subject: [PATCH] This is not a problem here if only for PHI placement, we may get rid of this `use` here. But as the comment said, it is useful if we are going to do code generation --- ext/opcache/Optimizer/zend_dfg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ext/opcache/Optimizer/zend_dfg.c b/ext/opcache/Optimizer/zend_dfg.c index abc9b3a1f5..d5be92d317 100644 --- a/ext/opcache/Optimizer/zend_dfg.c +++ b/ext/opcache/Optimizer/zend_dfg.c @@ -124,7 +124,8 @@ int zend_build_dfg(const zend_op_array *op_array, const zend_cfg *cfg, zend_dfg case ZEND_FETCH_OBJ_UNSET: case ZEND_VERIFY_RETURN_TYPE: op1_def: - // FIXME: include into "use" too ...? + /* `def` always come along with dtor or separation, + * thus the origin var info might be also `use`d in the feature(CG) */ DFG_SET(use, set_size, j, var_num); DFG_SET(def, set_size, j, var_num); break; -- 2.50.1