From c0b468366169ecf910f0ea209921e6f1cdbe4b57 Mon Sep 17 00:00:00 2001 From: Marcus Boerger Date: Tue, 25 Mar 2008 21:58:29 +0000 Subject: [PATCH] - MFH Use sizeof rather than strlen and cleanup --- sapi/cli/php_cli.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/sapi/cli/php_cli.c b/sapi/cli/php_cli.c index 29ff833dda..45c3944a7a 100644 --- a/sapi/cli/php_cli.c +++ b/sapi/cli/php_cli.c @@ -111,13 +111,13 @@ PHPAPI extern char *php_ini_scanned_files; #define PHP_MODE_REFLECTION_EXT_INFO 11 #define PHP_MODE_SHOW_INI_CONFIG 12 -#define HARDCODED_INI \ - "html_errors=0\n" \ - "register_argc_argv=1\n" \ - "implicit_flush=1\n" \ - "output_buffering=0\n" \ - "max_execution_time=0\n" \ - "max_input_time=-1\n" +const char HARDCODED_INI[] = + "html_errors=0\n" + "register_argc_argv=1\n" + "implicit_flush=1\n" + "output_buffering=0\n" + "max_execution_time=0\n" + "max_input_time=-1\n\0"; static char *php_optarg = NULL; static int php_optind = 1; @@ -659,10 +659,9 @@ int main(int argc, char *argv[]) setmode(_fileno(stderr), O_BINARY); /* make the stdio mode be binary */ #endif - ini_entries_len = strlen(HARDCODED_INI); - cli_sapi_module.ini_entries = malloc(ini_entries_len+2); - memcpy(cli_sapi_module.ini_entries, HARDCODED_INI, ini_entries_len+1); - cli_sapi_module.ini_entries[ini_entries_len+1] = 0; + ini_entries_len = sizeof(HARDCODED_INI)-2; + cli_sapi_module.ini_entries = malloc(sizeof(HARDCODED_INI)); + memcpy(cli_sapi_module.ini_entries, HARDCODED_INI, sizeof(HARDCODED_INI)); while ((c = php_getopt(argc, argv, OPTIONS, &php_optarg, &php_optind, 0, 2))!=-1) { switch (c) { -- 2.40.0