From bf5fc97eca006abbd8e099345b013b8ad10a59ea Mon Sep 17 00:00:00 2001 From: Ahmed Bougacha Date: Tue, 17 Jan 2017 19:54:18 +0000 Subject: [PATCH] [TLI] Appease spurious MSVC warning using llvm_unreachable. NFC. r292188 confused MSVC because of the combined lack of a default case and return statement. Move the unreachable outside of the NumLibFuncs case, to make it obvious that all cases should be handled. llvm_unreachable is __declspec(noreturn), so I'm assuming this does appease MSVC. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@292246 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Analysis/TargetLibraryInfo.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/Analysis/TargetLibraryInfo.cpp b/lib/Analysis/TargetLibraryInfo.cpp index 27e98035991..aea29e6359d 100644 --- a/lib/Analysis/TargetLibraryInfo.cpp +++ b/lib/Analysis/TargetLibraryInfo.cpp @@ -1177,9 +1177,10 @@ bool TargetLibraryInfoImpl::isValidProtoForLibFunc(const FunctionType &FTy, FTy.getParamType(1) == SizeTTy && FTy.getParamType(2) == SizeTTy); case LibFunc::NumLibFuncs: - llvm_unreachable("Invalid sentinel libfunc value"); + break; } + llvm_unreachable("Invalid libfunc"); } bool TargetLibraryInfoImpl::getLibFunc(const Function &FDecl, -- 2.50.1