From bf22d2707a2f47a7cc4caa239a14f2bf0a72bfd0 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Thu, 5 Mar 2015 12:11:26 -0300 Subject: [PATCH] Silence warning in non-assert-enabled build An OID return value was being used only for a (rather pointless) assert. Silence by removing the variable and the assert. Per note from Peter Geoghegan --- src/backend/catalog/pg_conversion.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/backend/catalog/pg_conversion.c b/src/backend/catalog/pg_conversion.c index 7de738722b..56ab016cc9 100644 --- a/src/backend/catalog/pg_conversion.c +++ b/src/backend/catalog/pg_conversion.c @@ -50,7 +50,6 @@ ConversionCreate(const char *conname, Oid connamespace, bool nulls[Natts_pg_conversion]; Datum values[Natts_pg_conversion]; NameData cname; - Oid oid; ObjectAddress myself, referenced; @@ -106,8 +105,7 @@ ConversionCreate(const char *conname, Oid connamespace, tup = heap_form_tuple(tupDesc, values, nulls); /* insert a new tuple */ - oid = simple_heap_insert(rel, tup); - Assert(OidIsValid(oid)); + simple_heap_insert(rel, tup); /* update the index if any */ CatalogUpdateIndexes(rel, tup); -- 2.40.0