From be4be2e2c466e342f1025a540322fac336ad0606 Mon Sep 17 00:00:00 2001 From: Zachary Turner Date: Sat, 16 Sep 2017 19:01:04 +0000 Subject: [PATCH] [llvm-symbolizer] Fix coff-dwarf.test This was a bug in the test that was only exposed as a result of refactoring some code in lit configuration files. Previously, llvm's lit configuration would only set the target-windows feature if the system was also windows. Since cross-compilation is a thing, this isn't correct. target-windows should be set independently of system-windows. Adding to that bug, this particular test then checked for target-windows when it really meant "can I call a certain API on the host machine", which is what system-windows is for. Ultimately, this test only works if *both* the target and host are Windows, so I've updated the test to reflect that. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@313468 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/tools/llvm-symbolizer/coff-dwarf.test | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/tools/llvm-symbolizer/coff-dwarf.test b/test/tools/llvm-symbolizer/coff-dwarf.test index 9611c891197..50763a6bde6 100644 --- a/test/tools/llvm-symbolizer/coff-dwarf.test +++ b/test/tools/llvm-symbolizer/coff-dwarf.test @@ -3,7 +3,7 @@ RUN: | llvm-symbolizer --inlining --relative-address -obj="%p/Inputs/coff-dw RUN: | FileCheck %s This test relies on UnDecorateSymbolName, which is Windows-only. -REQUIRES: target-windows +REQUIRES: target-windows, system-windows ADDR: 0x5009 ADDR: 0x5038 -- 2.40.0