From be116e2aab5e97d687f496ace0392e7701cf649f Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Mon, 9 Sep 2013 23:40:31 +0000 Subject: [PATCH] Adding a FIXME based on feedback from Richard Smith. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190369 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaDeclAttr.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/Sema/SemaDeclAttr.cpp b/lib/Sema/SemaDeclAttr.cpp index 0a35127980..78640d62df 100644 --- a/lib/Sema/SemaDeclAttr.cpp +++ b/lib/Sema/SemaDeclAttr.cpp @@ -1549,6 +1549,9 @@ static void handleWeakRefAttr(Sema &S, Decl *D, const AttributeList &Attr) { // static ((alias ("y"), weakref)). // Should we? How to check that weakref is before or after alias? + // FIXME: it would be good for us to keep the WeakRefAttr as-written instead + // of transforming it into an AliasAttr. The WeakRefAttr never uses the + // StringRef parameter it was given anyway. if (Attr.isArgExpr(0)) { Expr *Arg = Attr.getArgAsExpr(0); Arg = Arg->IgnoreParenCasts(); -- 2.40.0