From bd1f70ce99a054a8e1f4f8b809b08bbeeeab8fa4 Mon Sep 17 00:00:00 2001 From: Matthew Fernandez Date: Tue, 29 Mar 2022 07:59:05 -0700 Subject: [PATCH] remove build system support for 'lneato' `lneato` is built on top of `lefty` which is deprecated and will be removed in a future commit. --- CHANGELOG.md | 1 + ci/tests.py | 2 - cmd/Makefile.am | 2 +- cmd/lneato/Makefile.am | 52 ----------------- cmd/lneato/lneato.vcxproj | 97 ------------------------------- cmd/lneato/lneato.vcxproj.filters | 22 ------- configure.ac | 1 - graphviz.sln | 2 - redhat/graphviz.spec.fedora.in | 2 - rtest/test_tools.py | 1 - 10 files changed, 2 insertions(+), 180 deletions(-) delete mode 100644 cmd/lneato/Makefile.am delete mode 100644 cmd/lneato/lneato.vcxproj delete mode 100644 cmd/lneato/lneato.vcxproj.filters diff --git a/CHANGELOG.md b/CHANGELOG.md index 8ea800479..60778fc0b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 CMake build system - a brief note about the (previously undocumented) behavior of Graphviz when sent `SIGUSR1` is now mentioned in the man page +- build system support for `lneato` has been removed ### Fixed diff --git a/ci/tests.py b/ci/tests.py index b097773b2..a2d3faa26 100644 --- a/ci/tests.py +++ b/ci/tests.py @@ -78,7 +78,6 @@ def is_win64() -> bool: "gvpr", "gxl2dot", "gxl2gv", - "lneato", "mingle", "mm2gv", "neato", @@ -108,7 +107,6 @@ def test_existence(binary: str): "gvmap", "gvmap.sh", "gxl2dot", - "lneato", "prune", "vimdot", ] diff --git a/cmd/Makefile.am b/cmd/Makefile.am index 2e7b7aaf7..4c180930c 100644 --- a/cmd/Makefile.am +++ b/cmd/Makefile.am @@ -1,6 +1,6 @@ ## Process this file with automake to produce Makefile.in -SUBDIRS = dot tools gvpr lneato dotty gvmap gvedit mingle edgepaint +SUBDIRS = dot tools gvpr dotty gvmap gvedit mingle edgepaint if WITH_LEFTY SUBDIRS += lefty diff --git a/cmd/lneato/Makefile.am b/cmd/lneato/Makefile.am deleted file mode 100644 index fdd66e972..000000000 --- a/cmd/lneato/Makefile.am +++ /dev/null @@ -1,52 +0,0 @@ -## Process this file with automake to produce Makefile.in - -pdfdir = $(pkgdatadir)/doc/pdf - -if WITH_X -if WITH_WIN32 -bin_PROGRAMS = lneato -else -bin_SCRIPTS = lneato -endif -endif - -man_MANS = lneato.1 -if ENABLE_MAN_PDFS -pdf_DATA = lneato.1.pdf - -if HAVE_PS2PDF -pdf = $(pdf_DATA) -else -pdf = ERROR_NO_PS2PDF -endif -else -pdf = -endif - -AM_CPPFLAGS = \ - -I$(top_srcdir)/lib - -AM_CFLAGS = -DLNEATO -if WITH_WIN32 -lneato_SOURCES = ${top_srcdir}/cmd/dotty/mswin32/dotty.c -lneato_LDADD = -luser32 -lgdi32 -lwinspool -lcomdlg32 -ladvapi32 -lshell32 -else -lneato: ${top_srcdir}/cmd/lneato/lneato.sh - cp ${top_srcdir}/cmd/lneato/lneato.sh lneato - chmod +x lneato -endif - -if ENABLE_MAN_PDFS -if HAVE_PS2PDF -lneato.1.pdf: lneato.1.ps - @PS2PDF@ $< - -lneato.1.ps: $(srcdir)/lneato.1 - @GROFF@ -Tps -man $< >$@ -endif -endif - -EXTRA_DIST = $(man_MANS) $(pdf) lneato.bsh lneato.ksh lneato.sh \ - mswin32 lneato.vcxproj* - -DISTCLEANFILES = lneato $(pdf) lneato.1.ps diff --git a/cmd/lneato/lneato.vcxproj b/cmd/lneato/lneato.vcxproj deleted file mode 100644 index 3456b3748..000000000 --- a/cmd/lneato/lneato.vcxproj +++ /dev/null @@ -1,97 +0,0 @@ - - - - - Debug - Win32 - - - Release - Win32 - - - - {23D7A1F0-621B-474A-A45F-2490C9935C1E} - lneato - Win32Proj - 10.0 - - - - Application - v142 - - - Application - v142 - - - - - - - - - - - - - <_ProjectFileVersion>14.0.25123.0 - - - $(SolutionDir)$(Configuration)\Graphviz\bin\ - NativeRecommendedRules.ruleset - true - - - $(SolutionDir)$(Configuration)\Graphviz\bin\ - AllRules.ruleset - true - - - - Disabled - $(SolutionDir)lib;%(AdditionalIncludeDirectories) - _DEBUG;_CONSOLE;%(PreprocessorDefinitions) - EnableFastChecks - MultiThreadedDebugDLL - - Level4 - EditAndContinue - true - 4996 - - - true - Windows - - MachineX86 - - - - - $(SolutionDir)lib;%(AdditionalIncludeDirectories) - NDEBUG;_CONSOLE;%(PreprocessorDefinitions) - - Level4 - true - 4996 - - - - - No - Windows - true - true - - MachineX86 - - - - - - - - - \ No newline at end of file diff --git a/cmd/lneato/lneato.vcxproj.filters b/cmd/lneato/lneato.vcxproj.filters deleted file mode 100644 index ace087aad..000000000 --- a/cmd/lneato/lneato.vcxproj.filters +++ /dev/null @@ -1,22 +0,0 @@ - - - - - {93995380-89BD-4b04-88EB-625FBE52EBFB} - h;hpp;hxx;hm;inl;inc;xsd - - - {67DA6AB6-F800-4c08-8B7A-83BB121AAD01} - rc;ico;cur;bmp;dlg;rc2;rct;bin;rgs;gif;jpg;jpeg;jpe;resx - - - {4FC737F1-C7A5-4376-A066-2A32D752A2FF} - cpp;c;cc;cxx;def;odl;idl;hpj;bat;asm;asmx - - - - - Source Files - - - \ No newline at end of file diff --git a/configure.ac b/configure.ac index 02e15c657..267eb72df 100644 --- a/configure.ac +++ b/configure.ac @@ -2715,7 +2715,6 @@ AC_CONFIG_FILES(Makefile cmd/lefty/dot2l/Makefile cmd/lefty/examples/Makefile cmd/lefty/Makefile - cmd/lneato/Makefile cmd/dotty/Makefile cmd/smyrna/Makefile cmd/gvmap/Makefile diff --git a/graphviz.sln b/graphviz.sln index 564a5fef2..02ca112a5 100644 --- a/graphviz.sln +++ b/graphviz.sln @@ -121,8 +121,6 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "tred", "cmd\tools\tred.vcxp EndProject Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "dotty", "cmd\dotty\dotty.vcxproj", "{863A7931-DC7C-47C4-94E6-3D053BFE771A}" EndProject -Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "lneato", "cmd\lneato\lneato.vcxproj", "{23D7A1F0-621B-474A-A45F-2490C9935C1E}" -EndProject Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "unflatten", "cmd\tools\unflatten.vcxproj", "{0062B64B-88F1-4104-A063-3823925A7A34}" ProjectSection(ProjectDependencies) = postProject {C0663A08-F276-4DD6-B17C-E501EE066F7C} = {C0663A08-F276-4DD6-B17C-E501EE066F7C} diff --git a/redhat/graphviz.spec.fedora.in b/redhat/graphviz.spec.fedora.in index c614c59ef..5299521f7 100644 --- a/redhat/graphviz.spec.fedora.in +++ b/redhat/graphviz.spec.fedora.in @@ -320,10 +320,8 @@ Graphviz commands with X11 dependencies %license COPYING %endif %doc COPYING AUTHORS CHANGELOG.md NEWS README -%{_bindir}/lneato %{_bindir}/dotty %{_bindir}/vimdot -%{_mandir}/man1/lneato.1* %{_mandir}/man1/dotty.1* %{_mandir}/man1/vimdot.1* %if %{GTK} diff --git a/rtest/test_tools.py b/rtest/test_tools.py index efc402fd1..84aa42bd8 100644 --- a/rtest/test_tools.py +++ b/rtest/test_tools.py @@ -45,7 +45,6 @@ from gvtest import is_cmake, remove_xtype_warnings #pylint: disable=C0413 "gvpr", "gxl2dot", "gxl2gv", - "lneato", "mingle", "mm2gv", "neato", -- 2.40.0