From bc85dcd433d3304e43d0e56bc90dc39299c28b7c Mon Sep 17 00:00:00 2001 From: Kang Zhang Date: Sun, 11 Aug 2019 12:58:50 +0000 Subject: [PATCH] [NFC][CodeGen] Use while loop instead for loop in MachineBlockPlacement::optimizeBranches() This will pass EXPENSIVE check. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@368532 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/MachineBlockPlacement.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/CodeGen/MachineBlockPlacement.cpp b/lib/CodeGen/MachineBlockPlacement.cpp index 2f4060acbd7..3fd72b99089 100644 --- a/lib/CodeGen/MachineBlockPlacement.cpp +++ b/lib/CodeGen/MachineBlockPlacement.cpp @@ -2789,9 +2789,10 @@ void MachineBlockPlacement::optimizeBranches() { ChainBB->removeSuccessor(TBB); // Update the CFG. - for (MachineBasicBlock::pred_iterator PI = TBB->pred_begin(), - PE = TBB->pred_end(); PI != PE; ++PI) - (*PI)->ReplaceUsesOfBlockWith(TBB, ChainBB); + while (!TBB->pred_empty()) { + MachineBasicBlock *Pred = *(TBB->pred_end()-1); + Pred->ReplaceUsesOfBlockWith(TBB, ChainBB); + } for (MachineBasicBlock *Succ : TBB->successors()) ChainBB->addSuccessor(Succ, MBPI->getEdgeProbability(TBB, Succ)); -- 2.50.1