From bc7c99e7eca8d30d005e7d5db8b0aada2459fb15 Mon Sep 17 00:00:00 2001 From: Johann Date: Mon, 16 Jul 2018 12:25:15 -0700 Subject: [PATCH] Revert "Enable tpl model for speed 0" This reverts commit 9c2c234a0b8f9c08719ac1fa286988a0a3626fd0. Causes multithreading test failures in 32 bit configurations. BUG=webm:1547 Change-Id: Idb480b206a87b7cd6affbafffde8d8e1b6aee621 --- vp9/encoder/vp9_encodeframe.c | 13 ++++--------- vp9/encoder/vp9_speed_features.c | 4 ---- 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/vp9/encoder/vp9_encodeframe.c b/vp9/encoder/vp9_encodeframe.c index 5d92f7d10..e23a81b96 100644 --- a/vp9/encoder/vp9_encodeframe.c +++ b/vp9/encoder/vp9_encodeframe.c @@ -1958,10 +1958,10 @@ static void rd_pick_sb_modes(VP9_COMP *cpi, TileDataEnc *tile_data, if (cyclic_refresh_segment_id_boosted( get_segment_id(cm, map, bsize, mi_row, mi_col))) x->rdmult = vp9_cyclic_refresh_get_rdmult(cpi->cyclic_refresh); - } else { - if (cpi->sf.enable_tpl_model) x->rdmult = x->cb_rdmult; } + if (cpi->sf.enable_tpl_model) x->rdmult = x->cb_rdmult; + // Find best coding mode & reconstruct the MB so it is available // as a predictor for MBs that follow in the SB if (frame_is_intra_only(cm)) { @@ -2122,10 +2122,7 @@ static void encode_b(VP9_COMP *cpi, const TileInfo *const tile, ThreadData *td, PICK_MODE_CONTEXT *ctx) { MACROBLOCK *const x = &td->mb; set_offsets(cpi, tile, x, mi_row, mi_col, bsize); - - if (cpi->sf.enable_tpl_model && cpi->oxcf.aq_mode == NO_AQ) - x->rdmult = x->cb_rdmult; - + if (cpi->sf.enable_tpl_model) x->rdmult = x->cb_rdmult; update_state(cpi, td, ctx, mi_row, mi_col, bsize, output_enabled); encode_superblock(cpi, td, tp, output_enabled, mi_row, mi_col, bsize, ctx); @@ -3711,9 +3708,7 @@ static void rd_pick_partition(VP9_COMP *cpi, ThreadData *td, int rate_breakout_thr = cpi->sf.partition_search_breakout_thr.rate; int must_split = 0; - int partition_mul = cpi->sf.enable_tpl_model && cpi->oxcf.aq_mode == NO_AQ - ? x->cb_rdmult - : cpi->rd.RDMULT; + int partition_mul = cpi->sf.enable_tpl_model ? x->cb_rdmult : cpi->rd.RDMULT; (void)*tp_orig; diff --git a/vp9/encoder/vp9_speed_features.c b/vp9/encoder/vp9_speed_features.c index 80adf845e..31c416a71 100644 --- a/vp9/encoder/vp9_speed_features.c +++ b/vp9/encoder/vp9_speed_features.c @@ -843,11 +843,7 @@ void vp9_set_speed_features_framesize_independent(VP9_COMP *cpi) { sf->allow_quant_coeff_opt = sf->optimize_coefficients; sf->quant_opt_thresh = 99.0; sf->allow_acl = 1; -#if CONFIG_VP9_HIGHBITDEPTH sf->enable_tpl_model = 0; -#else - sf->enable_tpl_model = 1; -#endif for (i = 0; i < TX_SIZES; i++) { sf->intra_y_mode_mask[i] = INTRA_ALL; -- 2.40.0