From bb0ec7ba42c883dcedd4529d31998c90f9159ff8 Mon Sep 17 00:00:00 2001 From: Jan Wen Voung Date: Wed, 15 Jan 2014 21:42:41 +0000 Subject: [PATCH] Ensure i686-nacl long long is aligned 8 bytes (like malign-double) Set NaCl OSTargetInfo to have LongLongAlign = 64. Otherwise, it will pick up the setting of 32 from X86_32TargetInfo. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@199335 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Basic/Targets.cpp | 2 ++ test/CodeGen/long-double-x86-nacl.c | 7 ----- test/CodeGen/malign-double-x86-nacl.c | 43 +++++++++++++++++++++++++++ 3 files changed, 45 insertions(+), 7 deletions(-) delete mode 100644 test/CodeGen/long-double-x86-nacl.c create mode 100644 test/CodeGen/malign-double-x86-nacl.c diff --git a/lib/Basic/Targets.cpp b/lib/Basic/Targets.cpp index 9ce333d4af..6a3d57b405 100644 --- a/lib/Basic/Targets.cpp +++ b/lib/Basic/Targets.cpp @@ -619,6 +619,8 @@ public: this->DoubleAlign = 64; this->LongDoubleWidth = 64; this->LongDoubleAlign = 64; + this->LongLongWidth = 64; + this->LongLongAlign = 64; this->SizeType = TargetInfo::UnsignedInt; this->PtrDiffType = TargetInfo::SignedInt; this->IntPtrType = TargetInfo::SignedInt; diff --git a/test/CodeGen/long-double-x86-nacl.c b/test/CodeGen/long-double-x86-nacl.c deleted file mode 100644 index cec381a06b..0000000000 --- a/test/CodeGen/long-double-x86-nacl.c +++ /dev/null @@ -1,7 +0,0 @@ -// RUN: %clang_cc1 %s -emit-llvm -o - -triple=i686-unknown-nacl | FileCheck %s - -long double x = 0; -int checksize[sizeof(x) == 8 ? 1 : -1]; - -// CHECK-LABEL: define void @s1(double %a) -void s1(long double a) {} diff --git a/test/CodeGen/malign-double-x86-nacl.c b/test/CodeGen/malign-double-x86-nacl.c new file mode 100644 index 0000000000..d67315582b --- /dev/null +++ b/test/CodeGen/malign-double-x86-nacl.c @@ -0,0 +1,43 @@ +// RUN: %clang_cc1 %s -emit-llvm -o - -triple=i686-unknown-nacl | FileCheck %s +// Check that i686-nacl essentially has -malign-double, which aligns +// double, long double, and long long to 64-bits. + +int checksize[sizeof(long double) == 8 ? 1 : -1]; +int checkalign[__alignof(long double) == 8 ? 1 : -1]; + +// CHECK-LABEL: define void @s1(double %a) +void s1(long double a) {} + +struct st_ld { + char c; + long double ld; +}; +int checksize2[sizeof(struct st_ld) == 16 ? 1 : -1]; +int checkalign2[__alignof(struct st_ld) == 8 ? 1 : -1]; + +int checksize3[sizeof(double) == 8 ? 1 : -1]; +int checkalign3[__alignof(double) == 8 ? 1 : -1]; + +// CHECK-LABEL: define void @s2(double %a) +void s2(double a) {} + +struct st_d { + char c; + double d; +}; +int checksize4[sizeof(struct st_d) == 16 ? 1 : -1]; +int checkalign4[__alignof(struct st_d) == 8 ? 1 : -1]; + + +int checksize5[sizeof(long long) == 8 ? 1 : -1]; +int checkalign5[__alignof(long long) == 8 ? 1 : -1]; + +// CHECK-LABEL: define void @s3(i64 %a) +void s3(long long a) {} + +struct st_ll { + char c; + long long ll; +}; +int checksize6[sizeof(struct st_ll) == 16 ? 1 : -1]; +int checkalign6[__alignof(struct st_ll) == 8 ? 1 : -1]; -- 2.40.0