From ba6b92a929a2f798838f8809079126db4e85c941 Mon Sep 17 00:00:00 2001 From: Gunnar Beutner Date: Tue, 3 Mar 2015 09:23:38 +0100 Subject: [PATCH] Fix crash when specifying invalid argument for --autocomplete Coverity Bug ID: 1167734 --- icinga-app/icinga.cpp | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/icinga-app/icinga.cpp b/icinga-app/icinga.cpp index 3ca2ce933..0cb447a7b 100644 --- a/icinga-app/icinga.cpp +++ b/icinga-app/icinga.cpp @@ -96,7 +96,15 @@ int Main(void) if (argc >= 4 && strcmp(argv[1], "--autocomplete") == 0) { autocomplete = true; - autoindex = Convert::ToLong(argv[2]); + + try { + autoindex = Convert::ToLong(argv[2]); + } catch (const std::invalid_argument& ex) { + Log(LogCritical, "icinga-app") + << "Invalid index for --autocomplete: " << argv[2]; + return EXIT_FAILURE; + } + argc -= 3; argv += 3; } -- 2.49.0