From b9fe011cdfb0a3014e68a6e82007b6c2703a340b Mon Sep 17 00:00:00 2001 From: "Dmitry V. Levin" Date: Wed, 13 Dec 2006 16:59:44 +0000 Subject: [PATCH] 2006-12-10 Dmitry V. Levin Make several global variables static. #ifdef definitions of rarely unused functions. * defs.h (rflag, tflag, outfname): Remove. * strace.c (iflag, interactive, pflag_seen, rflag, tflag, outfname, username): Make static. * desc.c (sys_getdtablesize): Define only for ALPHA || FREEBSD || SUNOS4. * file.c (sys_fchroot): Define only for SUNOS4 || SVR4. (sys_mkfifo): Define only for FREEBSD. * mem.c (sys_sbrk): Define only for FREEBSD || SUNOS4. (sys_getpagesize): Define only for ALPHA || FREEBSD || IA64 || SUNOS4 || SVR4. * net.c (sys_so_socket): Define only for SVR4. * process.c (sys_gethostid): Define only for FREEBSD || SUNOS4 || SVR4. (sys_gethostname): Define only for ALPHA || FREEBSD || SUNOS4 || SVR4. (sys_setpgrp): Define only for ALPHA || SUNOS4 || SVR4. (sys_execv): Define only for SPARC || SPARC64 || SUNOS4. * signal.c (sys_sigblock): Define only for FREEBSD || SUNOS4. (sys_sighold, sys_sigwait): Define only for SVR4. (sys_killpg): Define only for FREEBSD || SUNOS4. * stream.c (sys_getmsg): Define only for SPARC || SPARC64 || SUNOS4 || SVR4. * syscall.c (sys_indir): Define only for SUNOS4. --- ChangeLog | 28 ++++++++++++++++++++++++++++ defs.h | 3 +-- desc.c | 2 ++ file.c | 4 ++++ mem.c | 4 ++++ net.c | 2 ++ process.c | 8 ++++++++ signal.c | 8 ++++++++ strace.c | 11 +++++------ stream.c | 2 ++ syscall.c | 2 ++ 11 files changed, 66 insertions(+), 8 deletions(-) diff --git a/ChangeLog b/ChangeLog index f7c87dcd..48817b71 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,31 @@ +2006-12-10 Dmitry V. Levin + + Make several global variables static. + #ifdef definitions of rarely unused functions. + * defs.h (rflag, tflag, outfname): Remove. + * strace.c (iflag, interactive, pflag_seen, rflag, tflag, + outfname, username): Make static. + * desc.c (sys_getdtablesize): Define only for + ALPHA || FREEBSD || SUNOS4. + * file.c (sys_fchroot): Define only for SUNOS4 || SVR4. + (sys_mkfifo): Define only for FREEBSD. + * mem.c (sys_sbrk): Define only for FREEBSD || SUNOS4. + (sys_getpagesize): Define only for + ALPHA || FREEBSD || IA64 || SUNOS4 || SVR4. + * net.c (sys_so_socket): Define only for SVR4. + * process.c (sys_gethostid): Define only for + FREEBSD || SUNOS4 || SVR4. + (sys_gethostname): Define only for + ALPHA || FREEBSD || SUNOS4 || SVR4. + (sys_setpgrp): Define only for ALPHA || SUNOS4 || SVR4. + (sys_execv): Define only for SPARC || SPARC64 || SUNOS4. + * signal.c (sys_sigblock): Define only for FREEBSD || SUNOS4. + (sys_sighold, sys_sigwait): Define only for SVR4. + (sys_killpg): Define only for FREEBSD || SUNOS4. + * stream.c (sys_getmsg): Define only for + SPARC || SPARC64 || SUNOS4 || SVR4. + * syscall.c (sys_indir): Define only for SUNOS4. + 2006-11-27 Dmitry V. Levin * system.c [LINUX]: Define CTL_PROC, since Linux 2.6.18+ headers diff --git a/defs.h b/defs.h index 312f28eb..f60b558d 100644 --- a/defs.h +++ b/defs.h @@ -409,9 +409,8 @@ struct xlat { extern struct tcb **tcbtab; extern int *qual_flags; extern int debug, followfork, followvfork; -extern int rflag, tflag, dtime, cflag, xflag, qflag; +extern int dtime, cflag, xflag, qflag; extern int acolumn; -extern char *outfname; extern unsigned int nprocs, tcbtabsize; extern int max_strlen; extern struct tcb *tcp_last; diff --git a/desc.c b/desc.c index 9cdabbb8..c3a7e6cc 100644 --- a/desc.c +++ b/desc.c @@ -391,12 +391,14 @@ struct tcb *tcp; return 0; } +#if defined(ALPHA) || defined(FREEBSD) || defined(SUNOS4) int sys_getdtablesize(tcp) struct tcb *tcp; { return 0; } +#endif /* ALPHA || FREEBSD || SUNOS4 */ static int decode_select(tcp, args, bitness) diff --git a/file.c b/file.c index cb0c5359..dbd16618 100644 --- a/file.c +++ b/file.c @@ -1824,6 +1824,7 @@ struct tcb *tcp; return 0; } +#if defined(SUNOS4) || defined(SVR4) int sys_fchroot(tcp) struct tcb *tcp; @@ -1833,6 +1834,7 @@ struct tcb *tcp; } return 0; } +#endif /* SUNOS4 || SVR4 */ int sys_link(tcp) @@ -2164,6 +2166,7 @@ sys_mknodat(struct tcb *tcp) } #endif +#ifdef FREEBSD int sys_mkfifo(tcp) struct tcb *tcp; @@ -2174,6 +2177,7 @@ struct tcb *tcp; } return 0; } +#endif /* FREEBSD */ int sys_fsync(tcp) diff --git a/mem.c b/mem.c index 618212a3..06da6e18 100644 --- a/mem.c +++ b/mem.c @@ -70,6 +70,7 @@ struct tcb *tcp; #endif } +#if defined(FREEBSD) || defined(SUNOS4) int sys_sbrk(tcp) struct tcb *tcp; @@ -79,6 +80,7 @@ struct tcb *tcp; } return RVAL_HEX; } +#endif /* FREEBSD || SUNOS4 */ static const struct xlat mmap_prot[] = { { PROT_NONE, "PROT_NONE", }, @@ -539,6 +541,7 @@ struct tcb *tcp; return 0; } +#if defined(ALPHA) || defined(FREEBSD) || defined(IA64) || defined(SUNOS4) || defined(SVR4) int sys_getpagesize(tcp) struct tcb *tcp; @@ -547,6 +550,7 @@ struct tcb *tcp; return RVAL_HEX; return 0; } +#endif /* ALPHA || FREEBSD || IA64 || SUNOS4 || SVR4 */ #if defined(LINUX) && defined(__i386__) void diff --git a/net.c b/net.c index c6270943..5c276eac 100644 --- a/net.c +++ b/net.c @@ -1205,6 +1205,7 @@ struct tcb *tcp; return 0; } +#ifdef SVR4 int sys_so_socket(tcp) struct tcb *tcp; @@ -1231,6 +1232,7 @@ struct tcb *tcp; } return 0; } +#endif /* SVR4 */ int sys_bind(tcp) diff --git a/process.c b/process.c index bea69a1b..06eb76e8 100644 --- a/process.c +++ b/process.c @@ -305,6 +305,7 @@ struct tcb *tcp; #endif /* HAVE_PRCTL */ +#if defined(FREEBSD) || defined(SUNOS4) || defined(SVR4) int sys_gethostid(tcp) struct tcb *tcp; @@ -313,6 +314,7 @@ struct tcb *tcp; return RVAL_HEX; return 0; } +#endif /* FREEBSD || SUNOS4 || SVR4 */ int sys_sethostname(tcp) @@ -325,6 +327,7 @@ struct tcb *tcp; return 0; } +#if defined(ALPHA) || defined(FREEBSD) || defined(SUNOS4) || defined(SVR4) int sys_gethostname(tcp) struct tcb *tcp; @@ -338,6 +341,7 @@ struct tcb *tcp; } return 0; } +#endif /* ALPHA || FREEBSD || SUNOS4 || SVR4 */ int sys_setdomainname(tcp) @@ -1473,6 +1477,7 @@ struct tcb *tcp; } #endif /* LINUX */ +#if defined(ALPHA) || defined(SUNOS4) || defined(SVR4) int sys_setpgrp(tcp) struct tcb *tcp; @@ -1484,6 +1489,7 @@ struct tcb *tcp; } return 0; } +#endif /* ALPHA || SUNOS4 || SVR4 */ int sys_getpgrp(tcp) @@ -1713,6 +1719,7 @@ long addr; tprintf(fmt, count, count == 1 ? "" : "s"); } +#if defined(SPARC) || defined(SPARC64) || defined(SUNOS4) int sys_execv(tcp) struct tcb *tcp; @@ -1733,6 +1740,7 @@ struct tcb *tcp; } return 0; } +#endif /* SPARC || SPARC64 || SUNOS4 */ int sys_execve(tcp) diff --git a/signal.c b/signal.c index fde89f28..41f9ad4e 100644 --- a/signal.c +++ b/signal.c @@ -1058,12 +1058,14 @@ struct tcb *tcp; return 0; } +#if defined(SUNOS4) || defined(FREEBSD) int sys_sigblock(tcp) struct tcb *tcp; { return sys_sigsetmask(tcp); } +#endif /* SUNOS4 || FREEBSD */ #endif /* !SVR4 */ @@ -1206,6 +1208,7 @@ struct tcb *tcp; } } +#ifdef SVR4 int sys_sighold(tcp) struct tcb *tcp; @@ -1215,6 +1218,7 @@ struct tcb *tcp; } return 0; } +#endif /* SVR4 */ #endif /* HAVE_SIGACTION */ @@ -1700,12 +1704,14 @@ struct tcb *tcp; return 0; } +#if defined(FREEBSD) || defined(SUNOS4) int sys_killpg(tcp) struct tcb *tcp; { return sys_kill(tcp); } +#endif /* FREEBSD || SUNOS4 */ #ifdef LINUX int @@ -1737,6 +1743,7 @@ struct tcb *tcp; return 0; } +#ifdef SVR4 int sys_sigwait(tcp) struct tcb *tcp; { @@ -1756,6 +1763,7 @@ struct tcb *tcp; } return 0; } +#endif /* SVR4 */ #ifdef LINUX diff --git a/strace.c b/strace.c index fd3f7bd2..7d5f86bc 100644 --- a/strace.c +++ b/strace.c @@ -63,21 +63,20 @@ #endif #endif -int debug = 0, followfork = 0, followvfork = 0, interactive = 0; -int rflag = 0, tflag = 0, dtime = 0, cflag = 0; -int iflag = 0, xflag = 0, qflag = 0; -int pflag_seen = 0; +int debug = 0, followfork = 0, followvfork = 0; +int dtime = 0, cflag = 0, xflag = 0, qflag = 0; +static int iflag = 0, interactive = 0, pflag_seen = 0, rflag = 0, tflag = 0; /* Sometimes we want to print only succeeding syscalls. */ int not_failing_only = 0; -char *username = NULL; +static char *username = NULL; uid_t run_uid; gid_t run_gid; int acolumn = DEFAULT_ACOLUMN; int max_strlen = DEFAULT_STRLEN; -char *outfname = NULL; +static char *outfname = NULL; FILE *outf; struct tcb **tcbtab; unsigned int nprocs, tcbtabsize; diff --git a/stream.c b/stream.c index eb72d622..9c24ad68 100644 --- a/stream.c +++ b/stream.c @@ -129,6 +129,7 @@ struct tcb *tcp; return 0; } +#if defined(SPARC) || defined(SPARC64) || defined(SUNOS4) || defined(SVR4) int sys_getmsg(tcp) struct tcb *tcp; @@ -175,6 +176,7 @@ struct tcb *tcp; } return RVAL_HEX | RVAL_STR; } +#endif /* SPARC || SPARC64 || SUNOS4 || SVR4 */ #if defined SYS_putpmsg || defined SYS_getpmsg static const struct xlat pmsgflags[] = { diff --git a/syscall.c b/syscall.c index 2e5053a4..05679ca4 100644 --- a/syscall.c +++ b/syscall.c @@ -2660,6 +2660,7 @@ struct tcb *tcp; return val; } +#ifdef SUNOS4 /* * Apparently, indirect system calls have already be converted by ptrace(2), * so if you see "indir" this program has gone astray. @@ -2682,6 +2683,7 @@ struct tcb *tcp; } return 0; } +#endif /* SUNOS4 */ static int time_cmp(a, b) -- 2.40.0