From b9d820b570ba522f3d89bb09f6f41618d3f5910b Mon Sep 17 00:00:00 2001 From: Jeff Trawick Date: Fri, 29 Dec 2000 14:11:12 +0000 Subject: [PATCH] Fix a segfault caused by mod_ext_filter when the external filter program does not exist. I wish I understood why I didn't hit this problem in the normal case :( git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87551 13f79535-47bb-0310-9956-ffa450edef68 --- CHANGES | 3 +++ modules/experimental/mod_ext_filter.c | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGES b/CHANGES index 0fa7d51789..6052e1f76a 100644 --- a/CHANGES +++ b/CHANGES @@ -1,5 +1,8 @@ Changes with Apache 2.0b1 + *) Fix a segfault caused by mod_ext_filter when the external filter + program does not exist. [Jeff Trawick] + *) Fix an output truncation error when on an HTTP >= 1.0 request an object of size between DEFAULT_BUCKET_SIZE and AP_MIN_BYTES_TO_WRITE was served through mod_charset_lite (or anything else that would diff --git a/modules/experimental/mod_ext_filter.c b/modules/experimental/mod_ext_filter.c index 5040ab1cf9..8f583420b3 100644 --- a/modules/experimental/mod_ext_filter.c +++ b/modules/experimental/mod_ext_filter.c @@ -421,7 +421,9 @@ static apr_status_t init_ext_filter_process(ap_filter_t *f) * be open. */ - apr_register_cleanup(ctx->p, ctx->proc->in, NULL, ef_close_file); + apr_register_cleanup(ctx->p, ctx->proc->in, + apr_null_cleanup, /* other mechanism */ + ef_close_file); #if APR_FILES_AS_SOCKETS { -- 2.40.0