From b99c666a940e93bcfcaeddc01515c94472e28a20 Mon Sep 17 00:00:00 2001 From: Anders Carlsson Date: Wed, 21 Apr 2010 20:28:29 +0000 Subject: [PATCH] Diagnose access to fields with private constructors. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@102025 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/clang/Basic/DiagnosticSemaKinds.td | 3 +++ lib/Sema/SemaAccess.cpp | 7 +++++++ 2 files changed, 10 insertions(+) diff --git a/include/clang/Basic/DiagnosticSemaKinds.td b/include/clang/Basic/DiagnosticSemaKinds.td index a5be82df86..eb53d6ca38 100644 --- a/include/clang/Basic/DiagnosticSemaKinds.td +++ b/include/clang/Basic/DiagnosticSemaKinds.td @@ -462,6 +462,9 @@ def err_access_ctor : def err_access_ctor_base : Error<"base class %0 has %select{private|protected}1 constructor">, NoSFINAE; +def err_access_ctor_field : + Error<"field of type %1 has %select{private|protected}2 constructor">, + NoSFINAE; def err_access_ctor_vbase : Error<"inherited virtual base class %0 has " "%select{private|protected}1 constructor">, diff --git a/lib/Sema/SemaAccess.cpp b/lib/Sema/SemaAccess.cpp index 1a96c26be1..f71d36ad7f 100644 --- a/lib/Sema/SemaAccess.cpp +++ b/lib/Sema/SemaAccess.cpp @@ -1150,6 +1150,13 @@ Sema::AccessResult Sema::CheckConstructorAccess(SourceLocation UseLoc, << Entity.getBaseSpecifier()->getType()); break; } + + case InitializedEntity::EK_Member: { + const FieldDecl *Field = cast(Entity.getDecl()); + AccessEntity.setDiag(PDiag(diag::err_access_ctor_field) + << Field->getDeclName() << Field->getType()); + break; + } } -- 2.50.1