From b8873558cf16893989778095cff342ae2adbc56a Mon Sep 17 00:00:00 2001 From: Ted Kremenek Date: Fri, 11 Apr 2008 20:51:02 +0000 Subject: [PATCH] Added FIXME git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@49558 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Analysis/CFRefCount.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/Analysis/CFRefCount.cpp b/lib/Analysis/CFRefCount.cpp index a9a7aaa117..27812f5a74 100644 --- a/lib/Analysis/CFRefCount.cpp +++ b/lib/Analysis/CFRefCount.cpp @@ -693,9 +693,13 @@ void CFRefCount::EvalCall(ExplodedNodeSet& Dst, break; } } - } - else if (isa(V)) // Nuke all arguments passed by reference. + } + else if (isa(V)) { // Nuke all arguments passed by reference. + + // FIXME: This is basically copy-and-paste from GRSimpleVals. We + // should compose behavior, not copy it. StateMgr.Unbind(StVals, cast(V)); + } } if (hasError) { @@ -733,6 +737,8 @@ void CFRefCount::EvalCall(ExplodedNodeSet& Dst, case RetEffect::NoRet: // Make up a symbol for the return value (not reference counted). + // FIXME: This is basically copy-and-paste from GRSimpleVals. We + // should compose behavior, not copy it. if (CE->getType() != Eng.getContext().VoidTy) { unsigned Count = Builder.getCurrentBlockCount(); -- 2.40.0