From b7e1ae2328f7d5a88d8916d78b4561d8ef16f99b Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Wed, 7 Dec 2016 12:39:24 -0500 Subject: [PATCH] Restore psql's SIGPIPE setting if popen() fails. Ancient oversight in PageOutput(): if popen() fails, we'd better reset the SIGPIPE handler before returning stdout, because ClosePager() won't. Noticed while fixing the empty-PAGER issue. --- src/fe_utils/print.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/fe_utils/print.c b/src/fe_utils/print.c index 5c5d285be5..daa23d1955 100644 --- a/src/fe_utils/print.c +++ b/src/fe_utils/print.c @@ -2884,6 +2884,8 @@ PageOutput(int lines, const printTableOpt *topt) pagerpipe = popen(pagerprog, "w"); if (pagerpipe) return pagerpipe; + /* if popen fails, silently proceed without pager */ + restore_sigpipe_trap(); } } -- 2.40.0