From b79cc9e7eb39c60a1f51e185490ea177252687e0 Mon Sep 17 00:00:00 2001 From: Chandler Carruth Date: Tue, 24 Jul 2018 03:18:08 +0000 Subject: [PATCH] [x86] Clean up and convert test to use generated CHECK lines. This test was already checking microscopic behavior of tail call under specific conditions. This just makes the CHECK lines much more consistent, clear, and easily updated when intentional changes are made. I've also switched the test to consistently name the entry block and to order the helper declarations and comments for specific tests in the more usual locations. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@337806 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/CodeGen/X86/tailcall-64.ll | 192 ++++++++++++++++++++------------ 1 file changed, 122 insertions(+), 70 deletions(-) diff --git a/test/CodeGen/X86/tailcall-64.ll b/test/CodeGen/X86/tailcall-64.ll index 65395a0947a..784254560cb 100644 --- a/test/CodeGen/X86/tailcall-64.ll +++ b/test/CodeGen/X86/tailcall-64.ll @@ -1,56 +1,71 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py ; RUN: llc -mtriple=x86_64-apple-macosx -mcpu=core2 < %s | FileCheck %s declare i64 @testi() define i64 @test_trivial() { +; CHECK-LABEL: test_trivial: +; CHECK: ## %bb.0: ## %entry +; CHECK-NEXT: jmp _testi ## TAILCALL +entry: %A = tail call i64 @testi() ret i64 %A } -; CHECK-LABEL: test_trivial: -; CHECK: jmp _testi ## TAILCALL - define i64 @test_noop_bitcast() { +; CHECK-LABEL: test_noop_bitcast: +; CHECK: ## %bb.0: ## %entry +; CHECK-NEXT: jmp _testi ## TAILCALL +entry: %A = tail call i64 @testi() %B = bitcast i64 %A to i64 ret i64 %B } -; CHECK-LABEL: test_noop_bitcast: -; CHECK: jmp _testi ## TAILCALL - ; Tail call shouldn't be blocked by no-op inttoptr. define i8* @test_inttoptr() { +; CHECK-LABEL: test_inttoptr: +; CHECK: ## %bb.0: ## %entry +; CHECK-NEXT: jmp _testi ## TAILCALL +entry: %A = tail call i64 @testi() %B = inttoptr i64 %A to i8* ret i8* %B } -; CHECK-LABEL: test_inttoptr: -; CHECK: jmp _testi ## TAILCALL - - declare <4 x float> @testv() define <4 x i32> @test_vectorbitcast() { +; CHECK-LABEL: test_vectorbitcast: +; CHECK: ## %bb.0: ## %entry +; CHECK-NEXT: jmp _testv ## TAILCALL +entry: %A = tail call <4 x float> @testv() %B = bitcast <4 x float> %A to <4 x i32> ret <4 x i32> %B } -; CHECK-LABEL: test_vectorbitcast: -; CHECK: jmp _testv ## TAILCALL - declare { i64, i64 } @testp() define {i64, i64} @test_pair_trivial() { +; CHECK-LABEL: test_pair_trivial: +; CHECK: ## %bb.0: ## %entry +; CHECK-NEXT: jmp _testp ## TAILCALL +entry: %A = tail call { i64, i64} @testp() ret { i64, i64} %A } -; CHECK-LABEL: test_pair_trivial: -; CHECK: jmp _testp ## TAILCALL define {i64, i64} @test_pair_notail() { +; CHECK-LABEL: test_pair_notail: +; CHECK: ## %bb.0: ## %entry +; CHECK-NEXT: pushq %rax +; CHECK-NEXT: .cfi_def_cfa_offset 16 +; CHECK-NEXT: callq _testi +; CHECK-NEXT: movq %rax, %rdx +; CHECK-NEXT: popq %rcx +; CHECK-NEXT: retq +entry: %A = tail call i64 @testi() %b = insertvalue {i64, i64} undef, i64 %A, 0 @@ -58,58 +73,70 @@ define {i64, i64} @test_pair_notail() { ret { i64, i64} %c } -; CHECK-LABEL: test_pair_notail: -; CHECK-NOT: jmp _testi define {i64, i64} @test_pair_extract_trivial() { +; CHECK-LABEL: test_pair_extract_trivial: +; CHECK: ## %bb.0: ## %entry +; CHECK-NEXT: jmp _testp ## TAILCALL +entry: %A = tail call { i64, i64} @testp() %x = extractvalue { i64, i64} %A, 0 %y = extractvalue { i64, i64} %A, 1 - + %b = insertvalue {i64, i64} undef, i64 %x, 0 %c = insertvalue {i64, i64} %b, i64 %y, 1 - + ret { i64, i64} %c } -; CHECK-LABEL: test_pair_extract_trivial: -; CHECK: jmp _testp ## TAILCALL - define {i64, i64} @test_pair_extract_notail() { +; CHECK-LABEL: test_pair_extract_notail: +; CHECK: ## %bb.0: ## %entry +; CHECK-NEXT: pushq %rax +; CHECK-NEXT: .cfi_def_cfa_offset 16 +; CHECK-NEXT: callq _testp +; CHECK-NEXT: movq %rax, %rcx +; CHECK-NEXT: movq %rdx, %rax +; CHECK-NEXT: movq %rcx, %rdx +; CHECK-NEXT: popq %rcx +; CHECK-NEXT: retq +entry: %A = tail call { i64, i64} @testp() %x = extractvalue { i64, i64} %A, 0 %y = extractvalue { i64, i64} %A, 1 - + %b = insertvalue {i64, i64} undef, i64 %y, 0 %c = insertvalue {i64, i64} %b, i64 %x, 1 - + ret { i64, i64} %c } -; CHECK-LABEL: test_pair_extract_notail: -; CHECK-NOT: jmp _testp - define {i8*, i64} @test_pair_extract_conv() { +; CHECK-LABEL: test_pair_extract_conv: +; CHECK: ## %bb.0: ## %entry +; CHECK-NEXT: jmp _testp ## TAILCALL +entry: %A = tail call { i64, i64} @testp() %x = extractvalue { i64, i64} %A, 0 %y = extractvalue { i64, i64} %A, 1 - + %x1 = inttoptr i64 %x to i8* - + %b = insertvalue {i8*, i64} undef, i8* %x1, 0 %c = insertvalue {i8*, i64} %b, i64 %y, 1 - + ret { i8*, i64} %c } -; CHECK-LABEL: test_pair_extract_conv: -; CHECK: jmp _testp ## TAILCALL - define {i64, i64} @test_pair_extract_multiple() { +; CHECK-LABEL: test_pair_extract_multiple: +; CHECK: ## %bb.0: ## %entry +; CHECK-NEXT: jmp _testp ## TAILCALL +entry: %A = tail call { i64, i64} @testp() %x = extractvalue { i64, i64} %A, 0 %y = extractvalue { i64, i64} %A, 1 - + %b = insertvalue {i64, i64} undef, i64 %x, 0 %c = insertvalue {i64, i64} %b, i64 %y, 1 @@ -118,74 +145,81 @@ define {i64, i64} @test_pair_extract_multiple() { %d = insertvalue {i64, i64} undef, i64 %x1, 0 %e = insertvalue {i64, i64} %b, i64 %y1, 1 - + ret { i64, i64} %e } -; CHECK-LABEL: test_pair_extract_multiple: -; CHECK: jmp _testp ## TAILCALL - define {i64, i64} @test_pair_extract_undef() { +; CHECK-LABEL: test_pair_extract_undef: +; CHECK: ## %bb.0: ## %entry +; CHECK-NEXT: jmp _testp ## TAILCALL +entry: %A = tail call { i64, i64} @testp() %x = extractvalue { i64, i64} %A, 0 - + %b = insertvalue {i64, i64} undef, i64 %x, 0 - + ret { i64, i64} %b } -; CHECK-LABEL: test_pair_extract_undef: -; CHECK: jmp _testp ## TAILCALL - declare { i64, { i32, i32 } } @testn() define {i64, {i32, i32}} @test_nest() { +; CHECK-LABEL: test_nest: +; CHECK: ## %bb.0: ## %entry +; CHECK-NEXT: jmp _testn ## TAILCALL +entry: %A = tail call { i64, { i32, i32 } } @testn() %x = extractvalue { i64, { i32, i32}} %A, 0 %y = extractvalue { i64, { i32, i32}} %A, 1 %y1 = extractvalue { i32, i32} %y, 0 %y2 = extractvalue { i32, i32} %y, 1 - + %b = insertvalue {i64, {i32, i32}} undef, i64 %x, 0 %c1 = insertvalue {i32, i32} undef, i32 %y1, 0 %c2 = insertvalue {i32, i32} %c1, i32 %y2, 1 %c = insertvalue {i64, {i32, i32}} %b, {i32, i32} %c2, 1 - + ret { i64, { i32, i32}} %c } -; CHECK-LABEL: test_nest: -; CHECK: jmp _testn ## TAILCALL - %struct.A = type { i32 } %struct.B = type { %struct.A, i32 } declare %struct.B* @testu() define %struct.A* @test_upcast() { +; CHECK-LABEL: test_upcast: +; CHECK: ## %bb.0: ## %entry +; CHECK-NEXT: jmp _testu ## TAILCALL entry: %A = tail call %struct.B* @testu() %x = getelementptr inbounds %struct.B, %struct.B* %A, i32 0, i32 0 ret %struct.A* %x } -; CHECK-LABEL: test_upcast: -; CHECK: jmp _testu ## TAILCALL - ; PR13006 define { i64, i64 } @crash(i8* %this) { +; CHECK-LABEL: crash: +; CHECK: ## %bb.0: ## %entry +; CHECK-NEXT: jmp _testp ## TAILCALL +entry: %c = tail call { i64, i64 } @testp() %mrv7 = insertvalue { i64, i64 } %c, i64 undef, 1 ret { i64, i64 } %mrv7 } -; Check that we can fold an indexed load into a tail call instruction. -; CHECK: fold_indexed_load -; CHECK: leaq (%rsi,%rsi,4), %[[rax:r..]] -; CHECK: jmpq *16(%{{r..}},%[[rax]],8) ## TAILCALL %struct.funcs = type { i32 (i8*, i32*, i32)*, i32 (i8*)*, i32 (i8*)*, i32 (i8*, i32)*, i32 } + @func_table = external global [0 x %struct.funcs] + +; Check that we can fold an indexed load into a tail call instruction. define void @fold_indexed_load(i8* %mbstr, i64 %idxprom) nounwind uwtable ssp { +; CHECK-LABEL: fold_indexed_load: +; CHECK: ## %bb.0: ## %entry +; CHECK-NEXT: leaq (%rsi,%rsi,4), %rax +; CHECK-NEXT: movq _func_table@{{.*}}(%rip), %rcx +; CHECK-NEXT: jmpq *16(%rcx,%rax,8) ## TAILCALL entry: %dsplen = getelementptr inbounds [0 x %struct.funcs], [0 x %struct.funcs]* @func_table, i64 0, i64 %idxprom, i32 2 %x1 = load i32 (i8*)*, i32 (i8*)** %dsplen, align 8 @@ -193,6 +227,8 @@ entry: ret void } +@funcs = external constant [0 x i32 (i8*, ...)*] + ; Fold an indexed load into the tail call instruction. ; Calling a varargs function with 6 arguments requires 7 registers (%al is the ; vector count for varargs functions). This leaves %r11 as the only available @@ -205,12 +241,20 @@ entry: ; int f(int n) { ; return funcs[n](0, 0, 0, 0, 0, 0); ; } -; -; CHECK-LABEL: rdar12282281 -; CHECK: jmpq *%r11 ## TAILCALL -@funcs = external constant [0 x i32 (i8*, ...)*] - define i32 @rdar12282281(i32 %n) nounwind uwtable ssp { +; CHECK-LABEL: rdar12282281: +; CHECK: ## %bb.0: ## %entry +; CHECK-NEXT: movslq %edi, %rax +; CHECK-NEXT: movq _funcs@{{.*}}(%rip), %rcx +; CHECK-NEXT: movq (%rcx,%rax,8), %r11 +; CHECK-NEXT: xorl %edi, %edi +; CHECK-NEXT: xorl %esi, %esi +; CHECK-NEXT: xorl %edx, %edx +; CHECK-NEXT: xorl %ecx, %ecx +; CHECK-NEXT: xorl %r8d, %r8d +; CHECK-NEXT: xorl %r9d, %r9d +; CHECK-NEXT: xorl %eax, %eax +; CHECK-NEXT: jmpq *%r11 ## TAILCALL entry: %idxprom = sext i32 %n to i64 %arrayidx = getelementptr inbounds [0 x i32 (i8*, ...)*], [0 x i32 (i8*, ...)*]* @funcs, i64 0, i64 %idxprom @@ -219,27 +263,35 @@ entry: ret i32 %call } +declare x86_fp80 @fp80_callee(x86_fp80) + define x86_fp80 @fp80_call(x86_fp80 %x) nounwind { -entry: ; CHECK-LABEL: fp80_call: -; CHECK: jmp _fp80_callee +; CHECK: ## %bb.0: ## %entry +; CHECK-NEXT: jmp _fp80_callee ## TAILCALL +entry: %call = tail call x86_fp80 @fp80_callee(x86_fp80 %x) nounwind ret x86_fp80 %call } -declare x86_fp80 @fp80_callee(x86_fp80) +declare double @trunc(double) nounwind readnone -; rdar://12229511 +; rdar://12229511 - Don't tail call trunc here. define x86_fp80 @trunc_fp80(x86_fp80 %x) nounwind { +; CHECK-LABEL: trunc_fp80: +; CHECK: ## %bb.0: ## %entry +; CHECK-NEXT: subq $24, %rsp +; CHECK-NEXT: fldt {{[0-9]+}}(%rsp) +; CHECK-NEXT: fstpl {{[0-9]+}}(%rsp) +; CHECK-NEXT: movsd {{.*#+}} xmm0 = mem[0],zero +; CHECK-NEXT: callq _trunc +; CHECK-NEXT: movsd %xmm0, {{[0-9]+}}(%rsp) +; CHECK-NEXT: fldl {{[0-9]+}}(%rsp) +; CHECK-NEXT: addq $24, %rsp +; CHECK-NEXT: retq entry: -; CHECK-LABEL: trunc_fp80 -; CHECK: callq _trunc -; CHECK-NOT: jmp _trunc -; CHECK: ret %conv = fptrunc x86_fp80 %x to double %call = tail call double @trunc(double %conv) nounwind readnone %conv1 = fpext double %call to x86_fp80 ret x86_fp80 %conv1 } - -declare double @trunc(double) nounwind readnone -- 2.50.1