From b74701043e396a93f1f18098044741daaf75f761 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Tue, 13 Jun 2017 10:54:39 -0400 Subject: [PATCH] In initdb, defend against assignment of NULL values to not-null columns. Previously, you could write _null_ in a BKI DATA line for a column that's supposed to be NOT NULL and initdb would let it pass, probably breaking subsequent accesses to the row. No doubt the original coding overlooked this simple sanity check because in the beginning we didn't have any way to mark catalog columns NOT NULL at initdb time. --- src/backend/bootstrap/bootstrap.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/backend/bootstrap/bootstrap.c b/src/backend/bootstrap/bootstrap.c index 4c28b2b821..d2708cb33e 100644 --- a/src/backend/bootstrap/bootstrap.c +++ b/src/backend/bootstrap/bootstrap.c @@ -843,6 +843,11 @@ InsertOneNull(int i) { elog(DEBUG4, "inserting column %d NULL", i); Assert(i >= 0 && i < MAXATTR); + if (boot_reldesc->rd_att->attrs[i]->attnotnull) + elog(ERROR, + "NULL value specified for not-null column \"%s\" of relation \"%s\"", + NameStr(boot_reldesc->rd_att->attrs[i]->attname), + RelationGetRelationName(boot_reldesc)); values[i] = PointerGetDatum(NULL); Nulls[i] = true; } -- 2.40.0