From b5b38adbe29cd82711595bd184d6123125bd9a9b Mon Sep 17 00:00:00 2001 From: Craig Silverstein Date: Mon, 8 Nov 2010 21:43:51 +0000 Subject: [PATCH] 1) Fix a typo in PPCallbacks: It's elif, not elfif. :-) This is contentful, since the typo was in the method-name... 2) Clarify some comments in RecursiveASTVisitor. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@118448 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/clang/AST/RecursiveASTVisitor.h | 9 +++++---- include/clang/Lex/PPCallbacks.h | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/include/clang/AST/RecursiveASTVisitor.h b/include/clang/AST/RecursiveASTVisitor.h index 5a76fab396..527d46f430 100644 --- a/include/clang/AST/RecursiveASTVisitor.h +++ b/include/clang/AST/RecursiveASTVisitor.h @@ -995,17 +995,18 @@ DEF_TRAVERSE_DECL(FileScopeAsmDecl, { }) DEF_TRAVERSE_DECL(FriendDecl, { - // At most one of these two will be non-NULL. - TRY_TO(TraverseDecl(D->getFriendDecl())); + // Friend is either decl or a type. if (D->getFriendType()) TRY_TO(TraverseTypeLoc(D->getFriendType()->getTypeLoc())); + else + TRY_TO(TraverseDecl(D->getFriendDecl())); }) DEF_TRAVERSE_DECL(FriendTemplateDecl, { - // At most one of these two will be non-NULL. - TRY_TO(TraverseDecl(D->getFriendDecl())); if (D->getFriendType()) TRY_TO(TraverseTypeLoc(D->getFriendType()->getTypeLoc())); + else + TRY_TO(TraverseDecl(D->getFriendDecl())); for (unsigned I = 0, E = D->getNumTemplateParameters(); I < E; ++I) { TemplateParameterList *TPL = D->getTemplateParameterList(I); for (TemplateParameterList::iterator ITPL = TPL->begin(), diff --git a/include/clang/Lex/PPCallbacks.h b/include/clang/Lex/PPCallbacks.h index 10bf6779f4..1946515302 100644 --- a/include/clang/Lex/PPCallbacks.h +++ b/include/clang/Lex/PPCallbacks.h @@ -228,7 +228,7 @@ public: } /// Elif -- This hook is called whenever an #if is seen. - virtual void ElfIf(SourceRange Range) { + virtual void Elif(SourceRange Range) { First->Elif(Range); Second->Elif(Range); } -- 2.50.1