From b5924ab73bcb8072a380470800e0499715f04d0f Mon Sep 17 00:00:00 2001 From: Lang Hames Date: Thu, 31 Aug 2017 01:09:56 +0000 Subject: [PATCH] [Orc] Add a comment about member variable dependencies to OrcMCJITReplacement. The comment explains the reason behind the change in member variable order in r312086. Thanks to Philip Reames for the suggestion. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@312205 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/ExecutionEngine/Orc/OrcMCJITReplacement.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/ExecutionEngine/Orc/OrcMCJITReplacement.h b/lib/ExecutionEngine/Orc/OrcMCJITReplacement.h index 743d5e2307c..cb48d6cb230 100644 --- a/lib/ExecutionEngine/Orc/OrcMCJITReplacement.h +++ b/lib/ExecutionEngine/Orc/OrcMCJITReplacement.h @@ -381,6 +381,9 @@ private: std::shared_ptr ClientResolver; Mangler Mang; + // IMPORTANT: ShouldDelete *must* come before LocalModules: The shared_ptr + // delete blocks in LocalModules refer to the ShouldDelete map, so + // LocalModules needs to be destructed before ShouldDelete. std::map ShouldDelete; std::vector> LocalModules; -- 2.50.1